8000 fix(ios): restore archived export share sheet by shroominic · Pull Request #80 · shroominic/OpenGlucose · GitHub
[go: up one dir, main page]

Skip to content

fix(ios): restore archived export share sheet - #80

Merged
shroominic merged 2 commits into
mainfrom
fix/ios-export-share-sheet
Aug 31, 2026
Merged

shroominic merged 2 commits into
mainfrom
fix/ios-export-share-sheet

Conversation

@shroominic
Copy link
Copy Markdown
Owner

Summary

Restores the iOS share sheet for archived sensor-data exports on iOS 26.

  • Replaces the affected share_plus iPhone presentation path with a small app-owned UIKit bridge.
  • Uses standard presentation on iPhone and an anchored popover only on iPad.
  • Accepts only the scoped export file that Flutter writes in the app cache; blocks traversal, symlink, nested-path, and unscoped-file access.
  • Retains existing cleanup and user-visible export behavior on every other platform.

Why

share_plus configures a popover on iPhone. On iOS 26 this can leave the activity controller stuck, so the Export data action appears to do nothing.

Verification

  • Full repository pre-push gate (make check): passed.
  • Focused Dart export tests: 22 passed.
  • Native iOS policy tests: 4 passed, including the production cache path.
  • Unsigned release iOS build: passed.
  • Independent review: ship after physical iOS smoke test.

Physical smoke test before release

On a real iOS 26 device: open export, cancel, Save to Files, swipe-dismiss, return from a share target, and export a second time.

@shroominic
shroominic merged commit 872bc2d into main Aug 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0