Repository navigation
Enforce the 99-character line length (hardening 3b) - #121
Merged
Merged
Conversation
Long messages are split into adjacent string literals inside brackets, long comments and docstring lines are rewrapped, and ruff format lays them out. Every Python file keeps the same syntax tree as before apart from docstring line breaks, except three hand edits that keep their behaviour: the terminal reason line in mix_cli, a benchmark input path joined in two parts, and the rewrapped verify_distribution smoke script. Text FlahaX writes out unchanged (report and sheet CSS, the benchmark Markdown page, the welcome screen, the docs GitHub icon) keeps its long lines with one `# noqa: E501` on the closing line of that string. E501 is no longer ignored, so the CI style job enforces 99 columns. CONTRIBUTING explains the rule; API_REFERENCE.md is regenerated for the two rewrapped docstring summaries.
This was referenced Oct 23, 2026
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
Enforce the 99-character line length (hardening 3b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening 3b, following #120: every line now fits in 99 columns, and the CI
stylejob enforces it.What changed
ruff formatlays the pieces out.mix_clishortens the terminal reason line in two steps instead of one long f-string;verify_distributionsmoke script is rewrapped.# noqa: E501on its closing line, because wrapping would change what FlahaX writes (9 strings in total).pyproject.tomlno longer ignores E501.API_REFERENCE.mdis regenerated for the two docstring summaries that now wrap.Evidence that nothing changed
main, apart from docstring line breaks. The only files that differ are the three hand edits above.run_batch, plus the batch and session sweeps) are identical tomain.tools/verify_distribution.pypasses (isolated wheel and sdist).-W --keep-going) passes.ruff check .andruff format --check .pass.