Repository navigation
Hardening 3a/4: PEP 8 formatting, file headers, CI style check - #120
Merged
Merged
Conversation
rafatahmed
added a commit
that referenced
this pull request
Nov 7, 2026
Hardening 3a/4: PEP 8 formatting, file headers, CI style check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third hardening PR, part a. Owner decisions 2026-10-23: PEP 8 at line length 99; the file-header template.
What changes
ruff format(PEP 8, 99 columns, existing quote style kept). It changes layout only, never meaning: one statement per line, PEP 8 spacing, blank lines and wrapping.flahax/__init__.py: one__all__list (135 names, identical) and__version__before the imports, replacing 13__all__ +=lines scattered between them; import order kept.p_factor); two lambdas assigned to names became functions; the ambiguous namelbecameline(checked with the tokenizer: only the 44 variable uses changed, no string or comment).pyproject.toml(ruff is a development tool, not a runtime dependency); a new CIstylejob runsruff checkandruff format --checkwith ruff 0.8.4 pinned;tests/test_file_headers.pychecks every header and the dunder order; CONTRIBUTING.md documents the conventions.Not yet
Line length (E501) is not enforced yet: 438 long strings, docstrings and comments are rewrapped by hand in 3b, which then turns the check on.
Proof it changes nothing
tools/verify_distribution.pyPASS; strict docs build; no Python 3.12-only syntax; LF.