Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sampling from a model with non-native byte-order transition or observation covariance silently changes the covariance values. For example, a positive-definite
float64covariance converted to>f8produces nearly zero noise on a little-endian machine, although its values and the sampling seed are unchanged.Normalize covariance byte order with a value-preserving dtype conversion. The shared helper works with NumPy 1 and 2 and avoids copying arrays whose byte order is already correct. Add public
sample()regressions for transition and observation covariance in all six filter classes, using bothfloat32andfloat64.Validation on Windows with Python 3.12.14:
pytest -q pykalman/tests pykalman/sqrt/tests— 65 passed, with 5 existing warnings in each environment.python pykalman/_nopytest_tests.py, Ruff 0.8.0 checks and formatting, andgit diff --cached --checkpassed.