Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM generated content, by GPT-6
Reference Issues/PRs
Found by passing each public update's return values into the next update; no existing issue is required to reproduce it.
What does this implement/fix? Explain your changes.
The three square-root filters return covariance shape
(1, n_dim_state, n_dim_state)fromfilter_update, although its documented return value and next call expect(n_dim_state, n_dim_state). Consequently, a second streaming update fails:Select the single reconstructed covariance at the return sites of
CholeskyKalmanFilter,BiermanKalmanFilterand the square-rootAdditiveUnscentedKalmanFilter. The reconstruction helper and batch methods retain their sequence shapes.Does your contribution introduce a new dependency? If yes, which one?
No.
What should a reviewer concentrate their feedback on?
Direct reuse of the returned covariance, including one-state filters and missing observations. Existing tests assign results into preallocated arrays, which hides the extra axis.
Did you add any tests for the change?
Twelve new cases fail before and pass after, checking consecutive updates against batch filtering and preserving inputs. The full suite passes 53 tests; configured pre-commit hooks pass. The new cases also pass with NumPy 1.26.4 as well as NumPy 2.5.3.
Any other comments?
A separate check on real ECG samples covers 72 streams and 43,128 updates across all three filters, one/two states, two noise levels and present/missing observations. All streams previously failed on direct reuse. After this change they complete and agree with an independent linear-Gaussian recurrence within 1.11e-14 for means and 7.61e-15 for covariances. All batch outputs remain identical. This validates streaming behavior, not physiological model accuracy.
PR checklist
[BUG].