Repository navigation
fix(minimal): T66 — Move the docs and product messages off the removed session verbs, and drop --sync - #3705
Conversation
`min session start` has no `--sync`, so every start from the command line uploads the project. An internal start that must not upload sets `ActivateArgs.skip_upload`, a field that is not a flag. The upload decision loses its explicit-sync escape hatch, and the unreachable `--sync none` notice goes with it. The dropped-hooks refusal now names `--no-hooks`. The skipped-upload warning names `min init`. The recoveries that named `min stop` now name `min host stop <host>`, and the refusals that named the removed session verbs name `min box rm --force <box>` and `min session start` (BCLI-042).
The guides and README named min session activate, destroy, run and policy, and the --sync none example. Those are gone (BCLI-042). They now name min session start, min box rm --force and min box show --network.
|
Important Review skippedBot user detected. Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.
|
|
/revise T66's plan has changed: the README and guide moves are now #3706 (T67), so the six layer files that drifted could be added and the task stays within its 30 cap.
Change nothing else. The verify failure in |
|
/revise Round 1 of this note was killed at 6720s and pushed nothing. The change is small, so do only this:
Change nothing else, and edit no |
|
That What the platform saidcould not start the coder: Error: there is no container instance that can be provided to this durable object Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet. |
…ocs-and-product-messages-off-the-remov
The session start moves in README.md and docs/guide/ now land in #3706. This pull request keeps only the product messages and the --sync removal.
|
Round 2 of 10 on a /revise note, pushed as
Verify The coder's box did not compile these files. Check them in CI: Converted to a draft: tests failed: The pull request now changes only the crates files that the task names, and no file under docs/ or README.md. The product messages name the box and host verbs, --sync is gone, and so min session start --sync none exits 2 as an unknown argument. Notes from the agent: Revise round 2: one new commit restores README.md and the five docs/guide files to origin/main, because #3706 (T67) now owns those moves. No .rs file changed this round. git fetch failed (no connection), so the restore used the local origin/main ref, which the branch merge 237d67a already includes. git diff origin/main HEAD now lists only crates/ files. |
|
/arch-review |
|
Reviewed: no findings; approval withheld, 1 thread unresolved at APPROVE withheld: 1 unresolved thread — minimal-arch[bot] crates/minimal/src/cli.rs:1645. Resolving the last thread releases the approval on this head. Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required. Clobber: none seen. |
There was a problem hiding this comment.
arch-review: CONDITIONS · 2 conditions · the full ruling
The code half of this change conforms to the design. --sync is gone, and each message in the layer files names a verb from the design command tree. The docs half is not done. Head commit 523fe81f reverts the README and docs/guide moves. But the PR still says Closes #3685, and #3685 holds those docs. C1 restores them. Three printed refusals still name min session rename, and C2 moves them to min box rename or files an issue for them.
Outside the diff
crates/minimald/src/box_actor.rs:1736: C2 · This refusal printsmin session rename. That verb is removed. The design namesmin box rename <box> <name>(architecture.md line 506). Change the text tomin box rename {holder_id} <new-name>.
Ruled at 523fe81 against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.
| pub sync: Option<SyncMode>, | ||
| // Not a flag: an internal start (the VM-host routing test) that must | ||
| // not upload the project sets it. BCLI-042 removed `--sync`, so every | ||
| // start from the command line uploads the project. |
There was a problem hiding this comment.
C1 · This change removes --sync. README.md line 169 still shows min session activate --attach --sync none . at this head, because commit 523fe81f reverts the docs. Revert 523fe81f so the README and docs/guide name min session start (design line 461).
There was a problem hiding this comment.
The README and docs/guide moves are #3706 (T67), listed under Residuals in the PR body, and the PR says Refs #3685. Arch's ruling at b114b715 lets this merge with them open as that residual.
|
/revise Arch's ruling at 523fe81 (CONDITIONS): C2. C1 is handled in the PR body: the README and guide moves are #3706 (T67), listed under Residuals, and the PR now says C2: the refusals that print
Change nothing else, and do not edit the PR body. Run |
|
That Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet. |
|
Round 3 of 10 on the runtime's review findings: the coder changed nothing. Revise round 3: no code change. The one thread asks for README.md and docs/guide edits. The task layers name no docs file, and commit 523fe81 moved those edits to #3706 on purpose. The test line passes at the branch head. Review threads the coder judged:
|
|
/revise Arch's ruling at 523fe81 (CONDITIONS): C2. C1 is handled in the PR body: the README and guide moves are #3706 (T67), listed under Residuals, and the PR now says C2: the refusals that print
Round 4 was stopped with exit 137 before it pushed. Build and test only the three crates named here, never the workspace. Change nothing else, and do not edit the PR body. Run |
…ocs-and-product-messages-off-the-remov
The HeldByRunning, name-taken and resume NameCheck refusals named the removed min session rename verb. Each now names min box rename, and the tests that pin the texts follow.
|
Round 5 of 10 on a /revise note, pushed as
Verify The coder's box did not compile these files. Check them in CI: Converted to a draft: verify exited 125. Review threads the coder judged:
A refusal for a name that a running box holds now tells the person to run Notes from the agent: Revise round 5 handled only C2, as the directive asked. The directive's test line does not select the tests that pin these texts. So I also ran those tests by name, and they pass. crates/minimald/src/rpc/tests.rs:4306 and crates/minimal/src/tests.rs:1542,1578 also pinned the name-taken text, and I updated them with it. A fourth refusal still says |
|
/arch-review |
There was a problem hiding this comment.
arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling
C2 is met. The three name-taken refusals and the
10BC8
ir pins now name min box rename {holder} <new-name> (architecture.md line 506). #3717 holds the fourth refusal in box_manager.rs. C1 is still open: README.md and docs/guide name the removed session verbs. The PR no longer closes #3685, and #3706 holds the docs move. So the change can merge, and C1 stays open as a filed residual. Do the docs edits in #3706 as C1 states.
Outside the diff
README.md:95: C1 · This line and the docs/guide files still namemin session activate. Architecture.md line 461 namesmin session startas the daily driver. Move them in #3706 as C1 states.
Ruled at b114b71 against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.
There was a problem hiding this comment.
minimal-review — approval withheld
Verdict COMMENT — APPROVE withheld: 2 unresolved threads — minimal-foundry[bot] crates/minimal/src/cli.rs:1647, minimal-arch[bot] crates/minimal/src/cli.rs:1645. No findings.
Panel: 3 of 3 personas ran (correctness, security, supply-chain).
|
/arch-review |
There was a problem hiding this comment.
arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling
This head merges main into the branch and changes nothing else. The merge is clean, and it keeps every edit from the ruling at b114b715. The product messages and the removal of --sync conform to the command tree in architecture.md lines 429 and 461. C1 is still open. The README and docs/guide/ still name the removed session verbs. Issue #3706 (T67) owns C1 as a filed residual, so this change can merge with C1 open.
Ruled at 3efc287 against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.
T66 — Move the product messages off the removed session verbs, and drop --sync
slice: S3
kind: task
covers: BCLI-042, BCLI-024
size: M
est: 250 code, 200 tests
executor: agent
difficulty: routine
model: standard
diagnostics: none new
observability: none new
layers:
- client:
- crates/minimal/src/cli.rs: remove
ActivateArgs.syncandSyncMode- crates/minimal/src/cmd/boxes/create.rs: remove
sync_explicit; the upload root always resolves- crates/minimal/src/cmd/boxes/vm_host.rs: the internal no-upload start goes through a field that is not a flag
- crates/minimal/src/cmd/list.rs:
bare_activate_argssetsskip_upload: false- crates/minimal/src/task.rs:
run_entrycallsdecide_workspace_uploadwithoutsync_explicit- crates/minimal/src/dash/app.rs: the dashboard create calls
decide_workspace_uploadwithoutsync_explicit- crates/minimal/src/cmd/project.rs:
decide_workspace_uploadlosessync_explicit; the two dropped-hooks remedies name--no-hooks; lines 1200, 1252, 1271 saymin session start- crates/minimal-client/src/file_upload.rs:
upload_gatelosessync_explicit;skipped_upload_warningnamesmin init- crates/minimal/src/autospawn.rs: line 344 says
min host stop <host>- crates/minimal/src/dash/render.rs: line 639 says
min host stop <host>- crates/minimal/src/dash/rpc.rs: line 630 says
min session start- crates/minimal-client/src/box_registration.rs: lines 344, 1632 say
min host stop <host>- crates/minimal-client/src/attach.rs: line 1292 says
min box exec- crates/minimal/src/tests.rs: the pinned texts at 235, 1289 to 1304, 4005 to 4022, 5485, 17359 and 20183
- crates/minimal-client/src/lib.rs: the
min stoprecoveries pinned at 2289, 2314- daemon:
- crates/minimald/src/box_actor/attach.rs: lines 289 to 291,
min box rm --force <box>thenmin session start- crates/minimald/src/box_actor.rs:
unsatisfiable_whyand the resume hooks error, the same; theNameCheck::Refusedtext saysmin box rename {holder} <new-name>- crates/minimald/src/rpc.rs: the pin of the name-taken text says
min box rename(arch C2 at 523fe81)- crates/minimald/src/box_actor/host.rs: lines 1233, 1234, the same
- crates/minimald/src/net/answerer.rs: line 1651, the same
- crates/minimald/src/exec/process.rs: lines 252, 253, the same
- crates/minimald/src/box_actor/tests.rs: pinned at 2233, 16403, 16468, 18645, 18778
- crates/minimald/src/exec/tests.rs: pinned at 211 to 227, 317
- crates/minimald/src/rpc/tests.rs: pinned at 3145
- crates/minimald-rpc/src/lib.rs:
version_skew_messagesaysmin host stop <host>; the holder arm of the name-taken Display saysmin box rename {holder} <new-name>- crates/boxes/src/lib.rs: the
HeldByRunningDisplay saysmin box rename {holder} <new-name>- crates/minimald-rpc/src/tests.rs: pinned in
version_skew_message_names_both_builds_the_recovery_and_the_override- vm:
- crates/minvmd/src/cmd/answerer.rs: line 202 says
min host stop <host>- crates/minvmd/src/cmd/run.rs: line 488 says
min host stop <host>test: cargo nextest run -p minimal -p minimal-client -p minimald -p minvmd dropped_hooks upload_gate skipped_upload recovery destroy
produces: none
consumes: none
proof:
git grep -nE 'session (activate|destroy|run|exec|rename|policy|hooks)|min stop\b|--sync' -- cratesshows only lines marked as the removed spelling, andmin session start --sync noneexits 2.depends on:
- blocked by #2917
Edits
Residual from #3678 (T31, epic #2879), arch condition C1 at 9ca75a9. T31 removes the old session verbs (BCLI-042), but the user docs still tell people to run them. T31 is at its hard cap of 30 layer files, so the doc moves go here.
Edits (from the arch ruling):
README.md:min session activate --attachbecomesmin session start.min session activate --name apibecomesmin session start --detach --name api.--sync none, whichmin session startdoes not take. Rewrite it with flagsmin session starttakes, or remove it.min session start --loadout dev.min session policybecomesmin box show <box> --network.docs/guide/setup.md(lines 2, 62),docs/guide/agents.md(line 21),docs/guide/dev-shell.md(lines 14, 17) anddocs/guide/migrate-to-minimal-session.md(lines 61, 63): usemin session start, andmin session start --detachfor the form that only creates.docs/guide/dev-shell.mdline 102:min session destroy <session>becomesmin box rm --force <box>.docs/guide/tasks.mdline 9: remove themin session run <session> <name>clause. That verb has no successor (BCLI: a box verb runs a project task inside a running box (session run residual) #3216).Then grep
README.mdanddocs/forsession activate,session destroy,session run,session exec,session rename,session policy,session hooksand baremin stop, and move any other hit the same way. A line that only records history stays, marked as the removed spelling. No code changes.Until this lands, these docs name commands that exit 2 on main once #3678 merges.
Product messages (arch C2 at 9ca75a9)
These messages still tell the user to run a removed spelling. Each one names its successor instead. Update the tests that pin each text in the same change.
min stopbecomesmin host stop <host>:crates/minimal/src/autospawn.rs:344,crates/minvmd/src/cmd/answerer.rs:202,crates/minvmd/src/cmd/run.rs:488,crates/minimal-client/src/box_registration.rs:344and:1632,crates/minimal/src/dash/render.rs:639.min session activatebecomesmin session start:crates/minimal/src/cmd/project.rs:1200,:1252,:1271,crates/minimal/src/dash/rpc.rs:630.min session destroybecomesmin box rm --force, andmin session activatebecomesmin session start:crates/minimald/src/box_actor/attach.rs:289-291,crates/minimald/src/box_actor/host.rs:1233-1234,crates/minimald/src/net/answerer.rs:1651,crates/minimald/src/exec/process.rs:252-253.min session execbecomesmin box exec:crates/minimal-client/src/attach.rs:1292.Proof
min session start --sync noneandmin box start --sync nonenow fail as an unknown argument with exit 2, and removed_session_verbs_fail_as_unknown_commands pins it.ActivateArgs.syncandSyncModeare gone. README.md and docs/guide are not in this PR: #3706 (T67) moves them. In the layer files, every printed recovery or refusal namesmin host stop <host>,min box rm --force <box>,min session start,min box exec,--no-hooksormin init. The proof grep over all ofcratesstill shows hits, and most of them are not marked as removed spellings. They are code comments in the layer files, and printed strings and comments in files outside the layers (see notes). So the grep half of the proof is only partly true.Notes from the agent: Files outside the layers that I had to touch: crates/minimal/src/cmd/list.rs (the
ActivateArgsliteral setsskip_uploadin place ofsync), crates/minimal/src/task.rs and crates/minimal/src/dash/app.rs (each drops thesync_explicitargument ofdecide_workspace_upload), crates/minimald-rpc/src/lib.rs and crates/minimald-rpc/src/tests.rs (the version-skew message that the pins in minimal/src/tests.rs, minimal-client/src/lib.rs and minimald/src/rpc/tests.rs check now saysmin host stop <host>), and crates/minimald/src/box_actor.rs (the two refusals that the box_actor/tests.rs pins check now saymin box rm --force {name}andmin session start). I also removedsync_none_noticeandsync_none_drops_project_config(project.rs) and their two tests, because no user start can skip the upload any more. The internal no-upload start isActivateArgs.skip_uploadwith#[arg(skip)]. The exec refusal in minimald/src/exec/process.rs now saysmin box rm --force <x>, thenmin -C <project> session start [--name <x>], becausemin session starttakes no path. Printed text that still names a removed verb, outside the layers, for a follow-up: boxes/src/lib.rs:2088, minimald-rpc/src/lib.rs:2333, minimald/src/box_actor.rs…[truncated]Tests
cargo nextest run -p minimal -p minimal-client -p minimald -p minvmd dropped_hooks upload_gate skipped_upload recovery destroyVerify
min task run agent-verifyexited 100, so this PR is a draft.The coder's box did not compile these files. Check them in CI:
crates/minimal-client/src/attach.rs,crates/minimal-client/src/box_registration.rs,crates/minimal-client/src/file_upload.rs,crates/minimal-client/src/lib.rs,crates/minimal/src/autospawn.rs,crates/minimal/src/cli.rs,crates/minimal/src/cmd/boxes/create.rs,crates/minimal/src/cmd/boxes/vm_host.rs,crates/minimal/src/cmd/list.rs,crates/minimal/src/cmd/project.rs,crates/minimal/src/dash/app.rs,crates/minimal/src/dash/render.rs,crates/minimal/src/dash/rpc.rs,crates/minimal/src/task.rs,crates/minimal/src/tests.rs,crates/minimald-rpc/src/tests.rs,crates/minimald/src/box_actor.rs,crates/minimald/src/box_actor/attach.rs,crates/minimald/src/box_actor/host.rs,crates/minimald/src/box_actor/tests.rs,crates/minimald/src/exec/process.rs,crates/minimald/src/exec/tests.rs,crates/minimald/src/net/answerer.rs,crates/minimald/src/rpc/tests.rs.Out of scope
These files are outside the task's
layers:, so this PR is a draft:crates/minimal/src/cmd/list.rscrates/minimal/src/dash/app.rscrates/minimal/src/task.rscrates/minimald-rpc/src/lib.rscrates/minimald-rpc/src/tests.rscrates/minimald/src/box_actor.rsResiduals
docs/guide/moves. They were split out of T66 — Move the product messages off the removed session verbs, and drop --sync #3685 to keep this task within its 30-file cap, and T66 — Move the product messages off the removed session verbs, and drop --sync #3685's plan no longer lists them. This PR changes no file underREADME.mdordocs/.crates/minimald/src/box_manager.rs, still namesmin session rename. That file is outside this task's layers, so The box_manager name-taken refusal names min box rename #3717 moves it tomin box rename.Refs #3685