8000 fix(minimal): T66 — Move the docs and product messages off the removed session verbs, and drop --sync by minimal-foundry[bot] · Pull Request #3705 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix(minimal): T66 — Move the docs and product messages off the removed session verbs, and drop --sync - #3705

Open
minimal-foundry[bot] wants to merge 8 commits into
mainfrom
agent/3685-move-the-docs-and-product-messages-off-the-remov
Open

minimal-foundry[bot] wants to merge 8 commits into
mainfrom
agent/3685-move-the-docs-and-product-messages-off-the-remov

Conversation

@minimal-foundry
@minimal-foundry minimal-foundry Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor

T66 — Move the product messages off the removed session verbs, and drop --sync

slice: S3
kind: task
covers: BCLI-042, BCLI-024
size: M
est: 250 code, 200 tests
executor: agent
difficulty: routine
model: standard
diagnostics: none new
observability: none new
layers:
- client:
- crates/minimal/src/cli.rs: remove ActivateArgs.sync and SyncMode
- crates/minimal/src/cmd/boxes/create.rs: remove sync_explicit; the upload root always resolves
- crates/minimal/src/cmd/boxes/vm_host.rs: the internal no-upload start goes through a field that is not a flag
- crates/minimal/src/cmd/list.rs: bare_activate_args sets skip_upload: false
- crates/minimal/src/task.rs: run_entry calls decide_workspace_upload without sync_explicit
- crates/minimal/src/dash/app.rs: the dashboard create calls decide_workspace_upload without sync_explicit
- crates/minimal/src/cmd/project.rs: decide_workspace_upload loses sync_explicit; the two dropped-hooks remedies name --no-hooks; lines 1200, 1252, 1271 say min session start
- crates/minimal-client/src/file_upload.rs: upload_gate loses sync_explicit; skipped_upload_warning names min init
- crates/minimal/src/autospawn.rs: line 344 says min host stop <host>
- crates/minimal/src/dash/render.rs: line 639 says min host stop <host>
- crates/minimal/src/dash/rpc.rs: line 630 says min session start
- crates/minimal-client/src/box_registration.rs: lines 344, 1632 say min host stop <host>
- crates/minimal-client/src/attach.rs: line 1292 says min box exec
- crates/minimal/src/tests.rs: the pinned texts at 235, 1289 to 1304, 4005 to 4022, 5485, 17359 and 20183
- crates/minimal-client/src/lib.rs: the min stop recoveries pinned at 2289, 2314
- daemon:
- crates/minimald/src/box_actor/attach.rs: lines 289 to 291, min box rm --force <box> then min session start
- crates/minimald/src/box_actor.rs: unsatisfiable_why and the resume hooks error, the same; the NameCheck::Refused text says min box rename {holder} <new-name>
- crates/minimald/src/rpc.rs: the pin of the name-taken text says min box rename (arch C2 at 523fe81)
- crates/minimald/src/box_actor/host.rs: lines 1233, 1234, the same
- crates/minimald/src/net/answerer.rs: line 1651, the same
- crates/minimald/src/exec/process.rs: lines 252, 253, the same
- crates/minimald/src/box_actor/tests.rs: pinned at 2233, 16403, 16468, 18645, 18778
- crates/minimald/src/exec/tests.rs: pinned at 211 to 227, 317
- crates/minimald/src/rpc/tests.rs: pinned at 3145
- crates/minimald-rpc/src/lib.rs: version_skew_message says min host stop <host>; the holder arm of the name-taken Display says min box rename {holder} <new-name>
- crates/boxes/src/lib.rs: the HeldByRunning Display says min box rename {holder} <new-name>
- crates/minimald-rpc/src/tests.rs: pinned in version_skew_message_names_both_builds_the_recovery_and_the_override
- vm:
- crates/minvmd/src/cmd/answerer.rs: line 202 says min host stop <host>
- crates/minvmd/src/cmd/run.rs: line 488 says min host stop <host>
test: cargo nextest run -p minimal -p minimal-client -p minimald -p minvmd dropped_hooks upload_gate skipped_upload recovery destroy
produces: none
consumes: none
proof: git grep -nE 'session (activate|destroy|run|exec|rename|policy|hooks)|min stop\b|--sync' -- crates shows only lines marked as the removed spelling, and min session start --sync none exits 2.
depends on:
- blocked by #2917

Edits

Residual from #3678 (T31, epic #2879), arch condition C1 at 9ca75a9. T31 removes the old session verbs (BCLI-042), but the user docs still tell people to run them. T31 is at its hard cap of 30 layer files, so the doc moves go here.

Edits (from the arch ruling):

  1. README.md:
    • lines 95 and 131: min session activate --attach becomes min session start.
    • line 105: min session activate --name api becomes min session start --detach --name api.
    • line 169: the example uses --sync none, which min session start does not take. Rewrite it with flags min session start takes, or remove it.
    • line 227: becomes min session start --loadout dev.
    • line 86: min session policy becomes min box show <box> --network.
  2. docs/guide/setup.md (lines 2, 62), docs/guide/agents.md (line 21), docs/guide/dev-shell.md (lines 14, 17) and docs/guide/migrate-to-minimal-session.md (lines 61, 63): use min session start, and min session start --detach for the form that only creates.
  3. docs/guide/dev-shell.md line 102: min session destroy <session> becomes min box rm --force <box>.
  4. docs/guide/tasks.md line 9: remove the min session run <session> <name> clause. That verb has no successor (BCLI: a box verb runs a project task inside a running box (session run residual) #3216).

Then grep README.md and docs/ for session activate, session destroy, session run, session exec, session rename, session policy, session hooks and bare min stop, and move any other hit the same way. A line that only records history stays, marked as the removed spelling. No code changes.

Until this lands, these docs name commands that exit 2 on main once #3678 merges.

Product messages (arch C2 at 9ca75a9)

These messages still tell the user to run a removed spelling. Each one names its successor instead. Update the tests that pin each text in the same change.

  • min stop becomes min host stop <host>: crates/minimal/src/autospawn.rs:344, crates/minvmd/src/cmd/answerer.rs:202, crates/minvmd/src/cmd/run.rs:488, crates/minimal-client/src/box_registration.rs:344 and :1632, crates/minimal/src/dash/render.rs:639.
  • min session activate becomes min session start: crates/minimal/src/cmd/project.rs:1200, :1252, :1271, crates/minimal/src/dash/rpc.rs:630.
  • min session destroy becomes min box rm --force, and min session activate becomes min session start: crates/minimald/src/box_actor/attach.rs:289-291, crates/minimald/src/box_actor/host.rs:1233-1234, crates/minimald/src/net/answerer.rs:1651, crates/minimald/src/exec/process.rs:252-253.
  • min session exec becomes min box exec: crates/minimal-client/src/attach.rs:1292.

Proof

min session start --sync none and min box start --sync none now fail as an unknown argument with exit 2, and removed_session_verbs_fail_as_unknown_commands pins it. ActivateArgs.sync and SyncMode are gone. README.md and docs/guide are not in this PR: #3706 (T67) moves them. In the layer files, every printed recovery or refusal names min host stop <host>, min box rm --force <box>, min session start, min box exec, --no-hooks or min init. The proof grep over all of crates still shows hits, and most of them are not marked as removed spellings. They are code comments in the layer files, and printed strings and comments in files outside the layers (see notes). So the grep half of the proof is only partly true.

Notes from the agent: Files outside the layers that I had to touch: crates/minimal/src/cmd/list.rs (the ActivateArgs literal sets skip_upload in place of sync), crates/minimal/src/task.rs and crates/minimal/src/dash/app.rs (each drops the sync_explicit argument of decide_workspace_upload), crates/minimald-rpc/src/lib.rs and crates/minimald-rpc/src/tests.rs (the version-skew message that the pins in minimal/src/tests.rs, minimal-client/src/lib.rs and minimald/src/rpc/tests.rs check now says min host stop <host>), and crates/minimald/src/box_actor.rs (the two refusals that the box_actor/tests.rs pins check now say min box rm --force {name} and min session start). I also removed sync_none_notice and sync_none_drops_project_config (project.rs) and their two tests, because no user start can skip the upload any more. The internal no-upload start is ActivateArgs.skip_upload with #[arg(skip)]. The exec refusal in minimald/src/exec/process.rs now says min box rm --force <x>, then min -C <project> session start [--name <x>], because min session start takes no path. Printed text that still names a removed verb, outside the layers, for a follow-up: boxes/src/lib.rs:2088, minimald-rpc/src/lib.rs:2333, minimald/src/box_actor.rs…[truncated]

Tests

line exit tail
cargo nextest run -p minimal -p minimal-client -p minimald -p minvmd dropped_hooks upload_gate skipped_upload recovery destroy 0 anup_destroy_queued_behind_a_running_finalize_keeps_the_session PASS [ 4.565s] (38/72) minimald box_actor::tests::a_destroyed_holders_shared_port_is_bound_for_the_running_box_that_takes_it PASS [ 0.248s] (39/72) minimald box_manager::tests::a_listing_survives_a_cleanup_destroy_of

Verify

min task run agent-verify exited 100, so this PR is a draft.

nimald box_actor::destroy_if_unfinalized_tests::destroy_if_unfinalized_destroys_a_pending_or_materializing_record
        PASS [   0.014s] (1378/3800) minimald box_actor::destroy_if_unfinalized_tests::destroy_if_unfinalized_keeps_a_stopped_or_exited_record
        PASS [   0.017s] (1379/3800) minimald box_actor::host::quic443_cohort_tests::cohort_flip_puts_member_leaves_in_the_blocked_set_over_launch_and_stop
        PASS [   0.026s] (1380/3800) minimald box_actor::host::quic443_cohort_tests::cohort_flip_puts_member_leaves_in_the_blocked_set_through_sudo_n
        PASS [   0.018s] (1381/3800) minimald box_actor::host::quic443_cohort_tests::host_ip_cohort_join_block_leave_drives_the_rule
        PASS [   0.018s] (1382/3800) minimald box_actor::host::quic443_cohort_tests::host_ip_cohort_join_block_leave_drives_the_rule_or_fails_the_launch
        PASS [   0.019s] (1383/3800) minimald box_actor::host::quic443_cohort_tests::host_ip_cohort_shell_exit_leaves_and_lifts_the_block
        PASS [   0.019s] (1384/3800) minimald box_actor::host::quic443_cohort_tests::lane_less_cohort_member_stays_out_of_the_proxy_lane_set
        PASS [   0.045s] (1385/3800) minimald box_actor::host::quic443_cohort_tests::root_leaf_set_change_runs_nft_on_the_named_set
        PASS [   0.020s] (1386/3800) minimald box_actor::tests::a_box_context_keys_task_state_on_the_records_project
        PASS [   0.250s] (1387/3800) minimald box_actor::tests::a_box_context_refuses_an_add_through_a_minimal_toml_that_links_out
        PASS [   1.123s] (1388/3800) minimal-client tty_relay::tests::suspend_keeps_head_and_drops_tail_past_bound
        PASS [   2.294s] (1389/3800) minimald box_actor::tests::a_box_destroyed_between_enumeration_and_grant_is_released_once
        PASS [   4.393s] (1390/3800) minimal-client tty_relay::tests::resume_after_drop_prints_line_and_nudges_winsize
        PASS [   2.283s] (1391/3800) minimald box_actor::tests::a_box_destroyed_inside_the_landing_window_is_not_resurrected
  stdout ───

    running 1 test
    test exec_run_attach_and_task_run_share_the_commands_trace ... FAILED

    failures:

    failures:
        exec_run_attach_and_task_run_share_the_commands_trace

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 5 filtered out; finished in 13.13s

  stderr ───

    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   2.284s] (1393/3800) minimald box_actor::tests::a_box_nobody_handed_an_address_publishes_at_the_answerers_grant
        PASS [   2.310s] (1394/3800) minimald box_actor::tests::a_box_holding_a_host_row_refuses_remint_after_its_host_loop_ends
        PASS [   2.300s] (1395/3800) minimald box_actor::tests::a_box_re_registered_inside_the_landing_window_keeps_its_grant
────────────
warning: 2405/3800 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

The coder's box did not compile these files. Check them in CI: crates/minimal-client/src/attach.rs, crates/minimal-client/src/box_registration.rs, crates/minimal-client/src/file_upload.rs, crates/minimal-client/src/lib.rs, crates/minimal/src/autospawn.rs, crates/minimal/src/cli.rs, crates/minimal/src/cmd/boxes/create.rs, crates/minimal/src/cmd/boxes/vm_host.rs, crates/minimal/src/cmd/list.rs, crates/minimal/src/cmd/project.rs, crates/minimal/src/dash/app.rs, crates/minimal/src/dash/render.rs, crates/minimal/src/dash/rpc.rs, crates/minimal/src/task.rs, crates/minimal/src/tests.rs, crates/minimald-rpc/src/tests.rs, crates/minimald/src/box_actor.rs, crates/minimald/src/box_actor/attach.rs, crates/minimald/src/box_actor/host.rs, crates/minimald/src/box_actor/tests.rs, crates/minimald/src/exec/process.rs, crates/minimald/src/exec/tests.rs, crates/minimald/src/net/answerer.rs, crates/minimald/src/rpc/tests.rs.

Out of scope

These files are outside the task's layers:, so this PR is a draft:

  • crates/minimal/src/cmd/list.rs
  • crates/minimal/src/dash/app.rs
  • crates/minimal/src/task.rs
  • crates/minimald-rpc/src/lib.rs
  • crates/minimald-rpc/src/tests.rs
  • crates/minimald/src/box_actor.rs

Residuals

Refs #3685

`min session start` has no `--sync`, so every start from the command
line uploads the project. An internal start that must not upload sets
`ActivateArgs.skip_upload`, a field that is not a flag. The upload
decision loses its explicit-sync escape hatch, and the unreachable
`--sync none` notice goes with it.

The dropped-hooks refusal now names `--no-hooks`. The skipped-upload
warning names `min init`. The recoveries that named `min stop` now name
`min host stop <host>`, and the refusals that named the removed session
verbs name `min box rm --force <box>` and `min session start` (BCLI-042).
The guides and README named min session activate, destroy, run and
policy, and the --sync none example. Those are gone (BCLI-042). They now
name min session start, min box rm --force and min box show --network.
@coderabbitai
coderabbitai Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cae76484-9674-468d-bd90-f06af5ee2b3e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@agent-137
Copy link
Copy Markdown
Member

/revise T66's plan has changed: the README and guide moves are now #3706 (T67), so the six layer files that drifted could be added and the task stays within its 30 cap.

  1. Restore README.md, docs/guide/agents.md, docs/guide/dev-shell.md, docs/guide/migrate-to-minimal-session.md, docs/guide/setup.md and docs/guide/tasks.md to their content on main. This PR changes no file under docs/ and leaves README.md alone.
  2. Keep every other change in this PR as it is, including the six files that were outside the old layers (cmd/list.rs, dash/app.rs, task.rs, minimald-rpc/src/lib.rs, minimald-rpc/src/tests.rs, minimald/src/box_actor.rs). They are in the plan now.

Change nothing else. The verify failure in exec_run_attach_and_task_run_share_the_commands_trace is the known flake #3483 and is not part of this round.

@agent-137
Copy link
Copy Markdown
Member

/revise Round 1 of this note was killed at 6720s and pushed nothing. The change is small, so do only this:

  1. git checkout origin/main -- README.md docs/guide/agents.md docs/guide/dev-shell.md docs/guide/migrate-to-minimal-session.md docs/guide/setup.md docs/guide/tasks.md. Those moves are now Move the README and guides off the removed session verbs #3706 (T67), and this PR changes no file under docs/ and leaves README.md alone.
  2. Keep every other change as it is. The six files that were outside the old layers are in the plan now.

Change nothing else, and edit no .rs file. CI is green at fdb903e, so the only test to run is the plan's: cargo nextest run -p minimal -p minimal-client -p minimald -p minvmd dropped_hooks upload_gate skipped_upload recovery destroy. The verify failure in exec_run_attach_and_task_run_share_the_commands_trace is the known flake #3483.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

That /revise is held, not dropped. The container platform had no instance to give the coder: its pool of prepared containers was full, which happens most just after a deploy. Your note is kept and asked again every 10 minutes for up to 30; a wait that outlives that is refused here with the reason.

What the platform said

could not start the coder: Error: there is no container instance that can be provided to this durable object

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

The session start moves in README.md and docs/guide/ now land in #3706.
This pull request keeps only the product messages and the --sync removal.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 2 of 10 on a /revise note, pushed as 523fe81f8693.

line exit tail
cargo nextest run -p minimal -p minimal-client -p minimald -p minvmd dropped_hooks upload_gate skipped_upload recovery destroy 101 ome/build/debug/deps/libopentelemetry_sdk-9be5e02e2a663845.rlib --extern orchestrator=/work/build-cache/cargo-home/build/debug/deps/liborchestrator-367320366d47e1ca.rlib --extern ot=/work/build-cache/cargo-home/build/debug/deps/libot-f7d366bdf87c04c2.rlib --extern paths=/work/build-cache/cargo-home/

Verify min task run agent-verify exited 100.

nimald box_actor::destroy_if_unfinalized_tests::destroy_if_unfinalized_destroys_a_pending_or_materializing_record
        PASS [   0.012s] (1379/3802) minimald box_actor::destroy_if_unfinalized_tests::destroy_if_unfinalized_keeps_a_stopped_or_exited_record
        PASS [   0.016s] (1380/3802) minimald box_actor::host::quic443_cohort_tests::cohort_flip_puts_member_leaves_in_the_blocked_set_over_launch_and_stop
        PASS [   0.020s] (1381/3802) minimald box_actor::host::quic443_cohort_tests::cohort_flip_puts_member_leaves_in_the_blocked_set_through_sudo_n
        PASS [   0.013s] (1382/3802) minimald box_actor::host::quic443_cohort_tests::host_ip_cohort_join_block_leave_drives_the_rule
        PASS [   0.014s] (1383/3802) minimald box_actor::host::quic443_cohort_tests::host_ip_cohort_join_block_leave_drives_the_rule_or_fails_the_launch
        PASS [   0.017s] (1384/3802) minimald box_actor::host::quic443_cohort_tests::host_ip_cohort_shell_exit_leaves_and_lifts_the_block
        PASS [   0.015s] (1385/3802) minimald box_actor::host::quic443_cohort_tests::lane_less_cohort_member_stays_out_of_the_proxy_lane_set
        PASS [   0.036s] (1386/3802) minimald box_actor::host::quic443_cohort_tests::root_leaf_set_change_runs_nft_on_the_named_set
        PASS [   0.014s] (1387/3802) minimald box_actor::tests::a_box_context_keys_task_state_on_the_records_project
        PASS [   0.223s] (1388/3802) minimald box_actor::tests::a_box_context_refuses_an_add_through_a_minimal_toml_that_links_out
        PASS [   1.098s] (1389/3802) minimal-client tty_relay::tests::suspend_keeps_head_and_drops_tail_past_bound
        PASS [   2.258s] (1390/3802) minimald box_actor::tests::a_box_destroyed_between_enumeration_and_grant_is_released_once
        PASS [   4.325s] (1391/3802) minimal-client tty_relay::tests::resume_after_drop_prints_line_and_nudges_winsize
        PASS [   2.280s] (1392/3802) minimald box_actor::tests::a_box_destroyed_inside_the_landing_window_is_not_resurrected
  stdout ───

    running 1 test
    test exec_run_attach_and_task_run_share_the_commands_trace ... FAILED

    failures:

    failures:
        exec_run_attach_and_task_run_share_the_commands_trace

    test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 5 filtered out; finished in 13.03s

  stderr ───

    ]
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

  Cancelling due to test failure: 3 tests still running
        PASS [   2.286s] (1394/3802) minimald box_actor::tests::a_box_holding_a_host_row_refuses_remint_after_its_host_loop_ends
        PASS [   2.249s] (1395/3802) minimald box_actor::tests::a_box_nobody_handed_an_address_publishes_at_the_answerers_grant
        PASS [   2.260s] (1396/3802) minimald box_actor::tests::a_box_re_registered_inside_the_landing_window_keeps_its_grant
────────────
warning: 2406/3802 tests were not run due to test failure (run with --no-fail-fast to run all tests, or run with --max-fail)
error: test run failed

The coder's box did not compile these files. Check them in CI: crates/minimal-client/src/attach.rs, crates/minimal-client/src/box_registration.rs, crates/minimal-client/src/file_upload.rs, crates/minimal-client/src/lib.rs, crates/minimal/src/autospawn.rs, crates/minimal/src/cli.rs, crates/minimal/src/cmd/boxes/create.rs, crates/minimal/src/cmd/boxes/vm_host.rs, crates/minimal/src/cmd/list.rs, crates/minimal/src/cmd/project.rs, crates/minimal/src/dash/app.rs, crates/minimal/src/dash/render.rs, crates/minimal/src/dash/rpc.rs, crates/minimal/src/task.rs, crates/minimal/src/tests.rs, crates/minimald-rpc/src/tests.rs, crates/minimald/src/box_actor.rs, crates/minimald/src/box_actor/attach.rs, crates/minimald/src/box_actor/host.rs, crates/minimald/src/box_actor/tests.rs, crates/minimald/src/exec/process.rs, crates/minimald/src/exec/tests.rs, crates/minimald/src/net/answerer.rs, crates/minimald/src/rpc/tests.rs.

Converted to a draft: tests failed: cargo nextest run -p minimal -p minimal-client -p minimald -p minvmd dropped_hooks upload_gate skipped_upload recovery destroy; verify exited 100.

The pull request now changes only the crates files that the task names, and no file under docs/ or README.md. The product messages name the box and host verbs, --sync is gone, and so min session start --sync none exits 2 as an unknown argument.

Notes from the agent: Revise round 2: one new commit restores README.md and the five docs/guide files to origin/main, because #3706 (T67) now owns those moves. No .rs file changed this round. git fetch failed (no connection), so the restore used the local origin/main ref, which the branch merge 237d67a already includes. git diff origin/main HEAD now lists only crates/ files.

@agent-137
agent-137 marked this pull request as ready for review November 21, 2026 02:15
@agent-137
agent-137 requested a review from a team as a code owner November 21, 2026 02:15
@agent-137
Copy link
Copy Markdown
Member

/arch-review

@minimal-foundry
minimal-foundry Bot commented Nov 21, 2026 •
Copy link
Copy Markdown
Contributor Author

Reviewed: no findings; approval withheld, 1 thread unresolved at 3efc28720773.

APPROVE withheld: 1 unresolved thread — minimal-arch[bot] crates/minimal/src/cli.rs:1645. Resolving the last thread releases the approval on this head.

Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

Comment thread crates/minimal/src/cli.rs Resolved
@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The code half of this change conforms to the design. --sync is gone, and each message in the layer files names a verb from the design command tree. The docs half is not done. Head commit 523fe81f reverts the README and docs/guide moves. But the PR still says Closes #3685, and #3685 holds those docs. C1 restores them. Three printed refusals still name min session rename, and C2 moves them to min box rename or files an issue for them.

Outside the diff

  • crates/minimald/src/box_actor.rs:1736: C2 · This refusal prints min session rename. That verb is removed. The design names min box rename <box> <name> (architecture.md line 506). Change the text to min box rename {holder_id} <new-name>.

Ruled at 523fe81 against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.

Comment thread crates/minimal/src/cli.rs
pub sync: Option<SyncMode>,
// Not a flag: an internal start (the VM-host routing test) that must
// not upload the project sets it. BCLI-042 removed `--sync`, so every
// start from the command line uploads the project.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C1 · This change removes --sync. README.md line 169 still shows min session activate --attach --sync none . at this head, because commit 523fe81f reverts the docs. Revert 523fe81f so the README and docs/guide name min session start (design line 461).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disputed — not addressed: The README and docs/guide moves are outside this task's layers. They belong to #3706 (T67), which the PR body lists under Residuals. Arch's ruling at 523fe81 says not to restore the docs here, so this PR does not revert 523fe81.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README and docs/guide moves are #3706 (T67), listed under Residuals in the PR body, and the PR says Refs #3685. Arch's ruling at b114b715 lets this merge with them open as that residual.

@agent-137
Copy link
Copy Markdown
Member

/revise Arch's ruling at 523fe81 (CONDITIONS): C2. C1 is handled in the PR body: the README and guide moves are #3706 (T67), listed under Residuals, and the PR now says Refs #3685. Do not restore the docs.

C2: the refusals that print min session rename, a removed verb, must name min box rename. Each becomes min box rename {holder} <new-name>:

  1. crates/boxes/src/lib.rs: the HeldByRunning Display (line 2088).
  2. crates/minimald-rpc/src/lib.rs: the holder arm of the name-taken Display (line 2333).
  3. crates/minimald/src/box_actor.rs: the NameCheck::Refused text (line 1736).
  4. Update the pin in crates/minimald/src/rpc.rs (line 4009) in the same change, and any other test that pins these texts.

Change nothing else, and do not edit the PR body. Run cargo nextest run -p boxes -p minimald-rpc -p minimald rename name_taken. The verify failure in exec_run_attach_and_task_run_share_the_commands_trace is the known flake #3483.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

That /revise is held, not dropped. A coder is already running on #3685. Your note is kept and goes into the next round here, which starts when that coder finishes.

Nothing to type again: the command gets a rocket when its round starts, or a refusal that names the reason. No round was counted for it yet.

@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 3 of 10 on the runtime's review findings: the coder changed nothing. Revise round 3: no code change. The one thread asks for README.md and docs/guide edits. The task layers name no docs file, and commit 523fe81 moved those edits to #3706 on purpose. The test line passes at the branch head.

Review threads the coder judged:

@agent-137
Copy link
Copy Markdown
Member

/revise Arch's ruling at 523fe81 (CONDITIONS): C2. C1 is handled in the PR body: the README and guide moves are #3706 (T67), listed under Residuals, and the PR now says Refs #3685. Do not restore the docs.

C2: the refusals that print min session rename, a removed verb, must name min box rename. Each becomes min box rename {holder} <new-name>:

  1. crates/boxes/src/lib.rs: the HeldByRunning Display (line 2088).
  2. crates/minimald-rpc/src/lib.rs: the holder arm of the name-taken Display (line 2333).
  3. crates/minimald/src/box_actor.rs: the NameCheck::Refused text (line 1736).
  4. Update the pin in crates/minimald/src/rpc.rs (line 4009) in the same change, and any other test that pins these texts.

Round 4 was stopped with exit 137 before it pushed. Build and test only the three crates named here, never the workspace.

Change nothing else, and do not edit the PR body. Run cargo nextest run -p boxes -p minimald-rpc -p minimald rename name_taken. The verify failure in exec_run_attach_and_task_run_share_the_commands_trace is the known flake #3483.

The HeldByRunning, name-taken and resume NameCheck refusals named the
removed min session rename verb. Each now names min box rename, and the
tests that pin the texts follow.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 5 of 10 on a /revise note, pushed as b114b7154736.

line exit tail
cargo nextest run -p minimal -p minimal-client -p minimald -p minvmd dropped_hooks upload_gate skipped_upload recovery destroy 0 anup_destroy_queued_behind_a_running_finalize_keeps_the_session PASS [ 4.484s] (38/72) minimald box_actor::tests::a_destroyed_holders_shared_port_is_bound_for_the_running_box_that_takes_it PASS [ 0.218s] (39/72) minimald box_manager::tests::a_listing_survives_a_cleanup_destroy_of

Verify min task run agent-verify exited 125.

1598732f210209,librusty_fork-63b1447cca486ad1,libwait_timeout-054d92a32ad45d8d,libfnv-3358953805330a63,libquick_error-d37dc27a83e74086,libbit_set-692c06cbb51b07e7,libbit_vec-9ad1f10dbed15c58,libtempfile-a0e916d9301e1bc8,libfastrand-fc003a2e9d98df4d,librustix-2a222f2d375ec288,libbitflags-3b49cf15bc6cb9e2,liblinux_raw_sys-98967cc47d31822c,libclient_config-b967f21a883cbf40,libtoml-2aea33601fef026d,libtoml_writer-14581a9d8fee7cd3,libtoml_parser-9d71f9449b11f073,libwinnow-0b86322c90e7afd1,libserde_spanned-d96ed742cfb92972,libtoml_datetime-be2b7a398aebdb67,libtracing-83feaaf26e80a884,libpin_project_lite-965c2dcbe863fe30,libtracing_core-84f58f17c6893e81,libonce_cell-9a2fd160c1da4076,libportable_atomic-0dd514cc30f274c2,libpaths-38d338f2d2882e54,libdirs-460e2d244a8fc274,libdirs_sys-5e8776d10c678365,liboption_ext-b0ea52c3b95d09a1,libthiserror-d936554554fa5dac,libcamino-0c63145602122330,libuuid-2ad4c678aa627cb6,libgetrandom-3bfdefd1957f2b79,liblibc-4f2d736fc0e30dce,librand_core-d44f5774360f5730,libcfg_if-5af2d58a3df8aa54,libserde-a2d31a39ef0e3ca2,libserde_core-149b29d4f6c47ae0}.rlib" "<sysroot>/lib64/rustlib/x86_64-unknown-linux-gnu/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-Wl,-Bdynamic" "-lgcc_s" "-lutil" "-lrt" "-lpthread" "-lm" "-ldl" "-lc" "-L" "/work/build-cache/cargo-home/build/debug/deps/rustcAlEWXa/raw-dylibs" "-Wl,--eh-frame-hdr" "-Wl,-z,noexecstack" "-L" "/work/build-cache/cargo-home/build/debug/build/tree-sitter-6abcf750100a3ada/out" "-L" "/work/build-cache/cargo-home/build/debug/build/tree-sitter-nickel-4d55240ed02e956b/out" "-L" "/work/build-cache/cargo-home/build/debug/build/blake3-493bdc0df5a171ff/out" "-L" "/work/build-cache/cargo-home/build/debug/build/aws-lc-sys-467e076f78a0a3c4/out" "-L" "/work/build-cache/cargo-home/build/debug/build/zstd-sys-0d91391d9ed43bde/out" "-L" "<sysroot>/lib64/rustlib/x86_64-unknown-linux-gnu/lib" "-o" "/work/build-cache/cargo-home/build/debug/deps/boxes-e8f0a3fc6b33c230" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: /usr/bin/ld: final link failed: No space left on device
          collect2: error: ld returned 1 exit status
          

error: could not compile `boxes` (lib test) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
rustc-LLVM ERROR: IO failure on output stream: No space left on device
error: could not compile `minimal` (test "git_remote")

Caused by:
  No space left on device (os error 28)

Caused by:
writing stderr I/O error at path : No space left on device (os error 28)
error: sandbox command failed.
Kept box runtime-implement-verify-1. Remove it with min box rm runtime-implement-verify-1.

The coder's box did not compile these files. Check them in CI: crates/minimal-client/src/attach.rs, crates/minimal-client/src/box_registration.rs, crates/minimal-client/src/file_upload.rs, crates/minimal-client/src/lib.rs, crates/minimal/src/autospawn.rs, crates/minimal/src/cli.rs, crates/minimal/src/cmd/boxes/create.rs, crates/minimal/src/cmd/boxes/vm_host.rs, crates/minimal/src/cmd/list.rs, crates/minimal/src/cmd/project.rs, crates/minimal/src/dash/app.rs, crates/minimal/src/dash/render.rs, crates/minimal/src/dash/rpc.rs, crates/minimal/src/task.rs, crates/minimal/src/tests.rs, crates/minimald-rpc/src/tests.rs, crates/minimald/src/box_actor.rs, crates/minimald/src/box_actor/attach.rs, crates/minimald/src/box_actor/host.rs, crates/minimald/src/box_actor/tests.rs, crates/minimald/src/exec/process.rs, crates/minimald/src/exec/tests.rs, crates/minimald/src/net/answerer.rs, crates/minimald/src/rpc.rs, crates/minimald/src/rpc/tests.rs.

Converted to a draft: verify exited 125.

Review threads the coder judged:

A refusal for a name that a running box holds now tells the person to run min box rename <holder> <new-name>. This applies to create, to the VM host registration and to resume or restart. No refusal names the removed min session rename verb.

Notes from the agent: Revise round 5 handled only C2, as the directive asked. The directive's test line does not select the tests that pin these texts. So I also ran those tests by name, and they pass. crates/minimald/src/rpc/tests.rs:4306 and crates/minimal/src/tests.rs:1542,1578 also pinned the name-taken text, and I updated them with it. A fourth refusal still says min session rename: crates/minimald/src/box_manager.rs:418, with its pin at crates/minimald/src/box_manager/tests.rs:4012. That file is not in the task's layers and the directive did not name it, so I did not change it. A follow-up must move it to min box rename. Only doc comments mention min session rename elsewhere. I did not run the workspace build or the full test suite.

@minimal-foundry
minimal-foundry Bot marked this pull request as draft November 21, 2026 05:44
@agent-137
agent-137 marked this pull request as ready for review November 21, 2026 05:45
@agent-137
Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

C2 is met. The three name-taken refusals and the 10BC8 ir pins now name min box rename {holder} <new-name> (architecture.md line 506). #3717 holds the fourth refusal in box_manager.rs. C1 is still open: README.md and docs/guide name the removed session verbs. The PR no longer closes #3685, and #3706 holds the docs move. So the change can merge, and C1 stays open as a filed residual. Do the docs edits in #3706 as C1 states.

Outside the diff

  • README.md:95: C1 · This line and the docs/guide files still name min session activate. Architecture.md line 461 names min session start as the daily driver. Move them in #3706 as C1 states.

Ruled at b114b71 against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 2 unresolved threads — minimal-foundry[bot] crates/minimal/src/cli.rs:1647, minimal-arch[bot] crates/minimal/src/cli.rs:1645. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@agent-137
Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

This head merges main into the branch and changes nothing else. The merge is clean, and it keeps every edit from the ruling at b114b715. The product messages and the removal of --sync conform to the command tree in architecture.md lines 429 and 461. C1 is still open. The README and docs/guide/ still name the removed session verbs. Issue #3706 (T67) owns C1 as a filed residual, so this change can merge with C1 open.

Ruled at 3efc287 against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0