8000 Merge branch 'main' into agent/3685-move-the-docs-and-product-messages-off-the-remov · gominimal/minimal@3efc287 · GitHub
[go: up one dir, main page]

Skip to content

Merge branch 'main' into agent/3685-move-the-docs-and-product-message…

Minimal Arch / arch-review completed Nov 21, 2026 in 0s

PASS_WITH_CONDITIONS

Inputs. Re-review of #3705 at 3efc2872, on arch 4f2eb87d, the same arch commit as the baseline. The baseline is the PASS_WITH_CONDITIONS ruling at b114b715. since-conditions.json holds its one condition, C1. since.diff is one merge of main (3efc2872), which brings in #3691 (env_vars), #3700 (T32, command model and reference) and #3702 (classifier). No findings.json or arch-map.md is staged. Those PRs have their own rulings in the ledger.

Governs. architecture.md Command tree (line 429): min session is list | start | attach | logs | stop | rm. Top-level commands (line 461): the daily driver is min session start, with no daily-loop shortcuts. min box (line 487): the min box start synopsis takes no --sync. The spec ids are BCLI-042 and BCLI-024 in docs/specs/28-spec-box-cli.

The compare. git show --cc 3efc2872 is empty, so the merge resolved no conflict by hand. Three files overlap pr.diff. In cli.rs the merge changes only the Session, Task and Box help lines. In cmd/boxes/create.rs it changes only wire_env_vars and is_secret_variable_name (#3691). In tests.rs it adds tests from main. One test pins a migration note that lists the removed spellings as history, which BCLI-042 allows. No PR edit is reverted. git grep finds no sync_explicit and no CLI SyncMode in crates/minimal at this head. Every ActivateArgs literal sets skip_upload or takes ..bare_activate_args(). The ruling at b114b715 stands for everything else.

Conditions. C1 is open. README.md (lines 86, 95, 105, 131, 169, 227) and docs/guide/ (setup.md, agents.md, dev-shell.md, migrate-to-minimal-session.md, tasks.md) still name min session activate, min session destroy, min session policy, min session run and --sync none at this head. It is a filed residual (#3706, T67), as at the baseline, so it does not block the merge. It is carried into conditions[].

Ruling. Both requirements conform in the code. The verdict and the open condition are the same as the baseline. This ruling does not depart from precedent.

Not checked. I did not compile, by the rules of this review. The PR body reports that agent-verify exited 100 with a failing test, exec_run_attach_and_task_run_share_the_commands_trace. CI must settle that test. The test is not a design question. gh is not on this host, so I did not confirm that #3706 and #3717 are open. I took them from the PR body and the baseline ruling.

Conditions

  • C1: Carried from the ruling at 523fe81, now as a filed residual (#3706, T67). In README.md (lines 86, 95, 105, 131, 169, 227), docs/guide/setup.md (lines 2, 62), docs/guide/agents.md (line 21), docs/guide/dev-shell.md (lines 14, 17, 102), docs/guide/migrate-to-minimal-session.md (lines 61, 63) and docs/guide/tasks.md (line 9), replace min session activate with min session start (--detach for the create-only form), min session destroy <session> with min box rm --force <box>, min session policy with min box show <box> --network, and remove the --sync none example and the min session run clause. Then git grep -nE 'session (activate|destroy|run|exec|rename|policy|hooks)|min stop\b|--sync' -- README.md docs/guide prints nothing.

Ruled at 3efc287 against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5; arch_rulings 1590, job 2be221f2-1b47-47b3-b37a-c893e1952f03.

0