8000 fix: the live Box Egress Proxy e2e cases run on the Linux KVM lane and no longer report NOT RUN for by minimal-foundry[bot] · Pull Request #3690 · gominimal/minimal · GitHub
[go: up one dir, main page]

Skip to content

fix: the live Box Egress Proxy e2e cases run on the Linux KVM lane and no longer report NOT RUN for - #3690

Open
minimal-foundry[bot] wants to merge 3 commits into
mainfrom
agent/3652-the-live-box-egress-proxy-e2e-cases-run-on-the-l
Open

minimal-foundry[bot] wants to merge 3 commits into
mainfrom
agent/3652-the-live-box-egress-proxy-e2e-cases-run-on-the-l

Conversation

@minimal-foundry
@minimal-foundry minimal-foundry Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor

Follow-up

Refs #3652

Task marker
### D3652 — The live Box Egress Proxy e2e cases run on the Linux KVM lane and no longer report NOT RUN for Linux
  kind: task
  size: S
  est: 80 code, 40 tests
  executor: agent
  origin: residual
  epic: 1501
  layers:
    - e2e:
      - scripts/session-e2e.sh: Remove the Darwin-only exit in bep_live_gate. Gate Linux on a reachable TPM or Secret Service, or on a lane key, and make the Keychain-only legs and comments correct for Linux.
      - justfile: Make the Linux minvmd-build recipe build bep beside the musl minvmd, so that minvmd and rt_bep_bin find it without MINVMD_BEP_BIN.
      test: bash scripts/session-e2e.sh bep_store_reference_end_to_end
      test: bash scripts/session-e2e.sh bep_second_box_needs_no_sign_in
  proof: On the Linux KVM lane, the bep cases print PASS. The lane summary shows no NOT RUN line with the reason that the live cases run on macOS lanes only.

Proof

On Linux, bep_live_gate no longer prints the NOT RUN reason that the live cases run on macOS lanes only. A Linux lane with a TPM or Secret Service that answers, or with E2E_BEP_KEY_STORE=1, starts the proxy and runs the bep cases. If the proxy does not come up there, the case fails. just minvmd-build on Linux puts bep beside the musl minvmd. Only partly delivered: bep_store_reference_end_to_end cannot print PASS on Linux, because min secret uses the macOS Keychain only. It now prints NOT RUN with that reason.

Residual: the Linux min secret store (architecture.md line 553, open gap 17). On Linux, bep::store returns StoreError::Unsupported, so bep_store_reference_end_to_end and the store leg of bep_dns_steering_through_the_box_zone_resolver print NOT RUN. Tracked in #3695.

Residual: no lane sets E2E_BEP_KEY_STORE or provides a TPM or Secret Service yet, so the Linux KVM lane does not show the bep cases as PASS. #3652 stays open for that.

Notes from the agent: I did not see PASS on the KVM lane. This box has no /dev/kvm, no TPM, no secret-tool, no musl toolchain and no network to fetch gvproxy. So both test lines report NOT RUN here, with the new reasons. The Linux cargo build -p bep --target <musl> is not built here. The release workflow builds bep for musl, so the target is known to work. The live gate on Linux uses a TPM (/dev/tpmrm0 that this user can read and write, plus tpm2_createprimary on PATH) or Secret Service (secret-tool lookup exits 0 or 1 with no error output), or the lane key E2E_BEP_KEY_STORE=1. The lane key skips the probe, so a proxy that then does not come up is a failure. A KVM lane must set it, or provide a store, to see PASS. The proof is not fully achievable for bep_store_reference_end_to_end: bep::store's non-macOS host module returns StoreError::Unsupported, so min secret set cannot work on Linux. That case and the store leg of bep_dns_steering_through_the_box_zone_resolver now record NOT RUN on Linux with that reason. The fail_closed leg of that case now checks the git box alone, or is NOT RUN when no leg started a box. A follow-up task is needed for a Linux min secret store. Not changed: proof_bep_ahm_missing_proxy_refused still has its own Darwin check ('the Box Egress Proxy runs on macOS only'). It is outside bep_live_gate, and the task did not name it. It can probably run on Linux now. shellcheck reports no new findings. I did not run commitl…[truncated]

Tests

line exit tail
bash scripts/session-e2e.sh bep_store_reference_end_to_end 0 ::warning::could not fetch the pinned gvproxy switch; native own-IP proofs will skip (stage /workbench/.scratch/gvproxy or install gvproxy-min under $MINIMAL_BIN) fetch-gvproxy: building gvproxy-linux-amd64 v0.9.0 from the pinned source build-gvproxy: downloading https://go.dev/dl/go1.26.10.linux-am
bash scripts/session-e2e.sh bep_second_box_needs_no_sign_in 0 ::warning::could not fetch the pinned gvproxy switch; native own-IP proofs will skip (stage /workbench/.scratch/gvproxy or install gvproxy-min under $MINIMAL_BIN) fetch-gvproxy: building gvproxy-linux-amd64 v0.9.0 from the pinned source build-gvproxy: downloading https://go.dev/dl/go1.26.10.linux-am

Verify

min task run agent-verify passed ([tasks.verify]).

Base

The base branch moved while the coder worked; it was merged in before the tests ran.

bep_live_gate no longer stops every Linux lane. On Linux it gates on a
TPM or Secret Service that answers, or on E2E_BEP_KEY_STORE=1 from the
lane. The Keychain-only store-reference case and the dns-steering store
leg are NOT RUN on Linux with that reason, since min secret uses the
macOS Keychain only. The Linux minvmd-build recipe now builds bep beside
the musl minvmd, so neither minvmd nor rt_bep_bin needs MINVMD_BEP_BIN.
@coderabbitai
coderabbitai Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

Ask an organization administrator to verify that this bot has an active assigned CodeRabbit review seat. See the seat-assignment guide. After the seat is confirmed, request a review again.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 40e8704c-962a-4e58-a3b4-30e989eebf7e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@minimal-foundry
minimal-foundry Bot commented Nov 20, 2026 •
Copy link
Copy Markdown
Contributor Author

Reviewed: no findings; approval withheld, 5 threads unresolved at d94b1ba83f32.

APPROVE withheld: 5 unresolved threads — minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh:14196, minimal-arch[bot] scripts/session-e2e.sh:14186. Resolving the last thread releases the approval on this head.

Resolve the open threads. Resolving the last one releases the approval on this head; no new review is required.

Verdict APPROVE, posted as a comment: the App cannot review its own pull request; the check and the label carry it.

Clobber: none seen.

@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — advisory review

Verdict COMMENT< 8000 /code> — 1 finding, 1 inline.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 3 conditions · the full ruling

The Linux gate and the recipe conform to Gatehouse §6.10. But the Linux NOT RUN legs that remain now have no issue that owns them, and the PR closes #3652. Section 6.10 line 844 and architecture.md line 553 leave the Linux min secret store open. File an issue for it, and name it in the store reasons (C1). No lane sets E2E_BEP_KEY_STORE, so the KVM lane does not yet show PASS. Change Fixes to Refs #3652, and name #3652 in the key-store reasons (C2). Remove the Darwin exit in proof_bep_ahm_missing_proxy_refused, because its reason is now false (C3).

Outside the diff

  • scripts/session-e2e.sh:19097: C3 · This reason says the proxy runs on macOS only, and this PR makes that false. check_github_grants and proxy_absence in crates/minimal/src/cmd/boxes/create.rs have no platform gate. Remove this Darwin block, and keep the gvproxy check.

Ruled at 04be33c against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
@norrietaylor
Copy link
Copy Markdown
Member

/revise
Arch ruled CONDITIONS at 04be33c (3 conditions). Do these:

  1. C1. The Linux min secret store is now tracked in min secret and Box Egress Proxy store references have no host store on Linux #3695. Name min secret and Box Egress Proxy store references have no host store on Linux #3695 in the NOT RUN reasons that bep_store_reference_end_to_end and the store leg of bep_dns_steering_through_the_box_zone_resolver print on Linux, and list it as a residual in the PR body.
  2. C2. No lane sets E2E_BEP_KEY_STORE yet, so the KVM lane does not show PASS. In the PR body, change Fixes #3652 to Refs #3652. Name Run the Box Egress Proxy e2e cases on Linux #3652 in the key-store NOT RUN reason that bep_live_gate prints when no TPM, Secret Service or E2E_BEP_KEY_STORE is found.
  3. C3. In scripts/session-e2e.sh, remove the Darwin-only exit in proof_bep_ahm_missing_proxy_refused (about line 19097). Its reason, "the Box Egress Proxy runs on macOS only", is false after this PR. check_github_grants and proxy_absence in crates/minimal/src/cmd/boxes/create.rs have no platform gate. Keep the gvproxy check.

Run shellcheck scripts/session-e2e.sh and bash scripts/session-e2e.sh bep_store_reference_end_to_end, and record both in the Tests table.

Name #3652 in the key-store reason and #3695 in the min secret store
reasons. Remove the Darwin-only exit in the missing-proxy case, since the
Box Egress Proxy now runs on Linux too. The gvproxy check stays.
@minimal-foundry
Copy link
Copy Markdown
Contributor Author

Round 1 of 10 on a /revise note, pushed as d94b1ba83f32.

line exit tail
bash scripts/session-e2e.sh bep_store_reference_end_to_end 0 ::warning::could not fetch the pinned gvproxy switch; native own-IP proofs will skip (stage /workbench/.scratch/gvproxy or install gvproxy-min under $MINIMAL_BIN) fetch-gvproxy: building gvproxy-linux-amd64 v0.9.0 from the pinned source build-gvproxy: downloading https://go.dev/dl/go1.26.10.linux-am
bash scripts/session-e2e.sh bep_second_box_needs_no_sign_in 0 ::warning::could not fetch the pinned gvproxy switch; native own-IP proofs will skip (stage /workbench/.scratch/gvproxy or install gvproxy-min under $MINIMAL_BIN) fetch-gvproxy: building gvproxy-linux-amd64 v0.9.0 from the pinned source build-gvproxy: downloading https://go.dev/dl/go1.26.10.linux-am

Verify min task run agent-verify passed.

Review threads the coder judged:

On Linux, no bep case reports NOT RUN because the Box Egress Proxy runs on macOS only. The missing-proxy case now runs on Linux when gvproxy is present. A Linux run without a key store prints a NOT RUN reason that names #3652. The Keychain-only store cases name #3695. The KVM lane does not show PASS for the bep cases yet, because no lane sets E2E_BEP_KEY_STORE.

Notes from the agent: Revise round 1. C1: the bep_native_store_gate reason and the dns-steering store leg reason now end with '; Linux: #3695'. C2: both key-store NOT RUN reasons in bep_linux_key_store end with '; #3652'. C3: I removed the Darwin-only exit in proof_bep_ahm_missing_proxy_refused, and the gvproxy check stays. I cannot edit the PR body. The runner must change 'Fixes #3652' to 'Refs #3652' and list #3695 as a residual. This box has no KVM, no TPM, no Secret Service and no network to go.dev for gvproxy. So both test lines exit 0 with NOT RUN, not PASS, and the proof on the KVM lane is not observed here. The printed reasons contain issue URLs because the directive asks for them.

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: CONDITIONS · 2 conditions · the full ruling

The script changes meet the earlier conditions. C3 is met, and the NOT RUN reasons now name #3652 and #3695. Two edits to the PR body are still open. C1: list the Linux min secret store as a residual with issue #3695 (architecture.md line 553, open gap 17). C2: change Fixes #3652 to Refs #3652. The Linux key-store NOT RUN lines name #3652 as their owner, and no lane shows the bep cases as PASS yet.

Ruled at d94b1ba against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
Comment thread scripts/session-e2e.sh Resolved
@minimal-foundry minimal-foundry Bot left a comment
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minimal-review — approval withheld

Verdict COMMENT — APPROVE withheld: 5 unresolved threads — minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh, minimal-arch[bot] scripts/session-e2e.sh:14196, minimal-arch[bot] scripts/session-e2e.sh:14186. No findings.

Panel: 3 of 3 personas ran (correctness, security, supply-chain).

@norrietaylor
Copy link
Copy Markdown
Member

/arch-review

@minimal-arch minimal-arch Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch-review: PASS_WITH_CONDITIONS · 1 condition · the full ruling

The change conforms to the design. On Linux, the gate now probes the TPM and Secret Service. Gatehouse §6.10 lines 837 and 844 name these stores for Linux. The min secret legs are NOT RUN on Linux and name #3695. That is correct, because architecture.md line 553 leaves the Linux default store open (gap 17). Nobody saw the task's proof yet: no Linux KVM lane prints PASS for the bep cases. C1 carries that proof, and it is filed as #3652, so the PR can merge with C1 open.

Ruled at d94b1ba against gominimal/arch@4f2eb87d5d12 by claude-opus-5-5.

Comment thread scripts/session-e2e.sh Resolved
@norrietaylor
Copy link
Copy Markdown
Member

/review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0