8000 Retype the manifest envelope in set_specification_type by bboe · Pull Request #648 · bazeltools/rules_minidock_tools · GitHub
[go: up one dir, main page]

Skip to content

Retype the manifest envelope in set_specification_type - #648

Merged
bboe merged 1 commit into
mainfrom
fix/set-specification-type-manifest-envelope
Jul 15, 2026
Merged

bboe merged 1 commit into
mainfrom
fix/set-specification-type-manifest-envelope

Conversation

@bboe
@bboe bboe commented Jul 15, 2026
Copy link
Copy Markdown
Contributor

set_specification_type retyped the config and each layer but not the manifest's own specification_type. Since the serialized top-level mediaType derives from it, requesting OCI left the envelope as the base image's docker v2s2 while config/layers became OCI -- a non-conformant image: a docker v2s2 manifest referencing OCI layer media types (application/vnd.oci.image.layer.v1.tar+gzip and +zstd).

Strict OCI/distribution-spec tooling built on containers-image (skopeo, podman, buildah) rejects this with "unsupported docker v2s2 media type"; the docker CLI is lenient and accepts it.

Spec: https://github.com/opencontainers/image-spec/blob/main/media-types.md

`set_specification_type` retyped the config and each layer but not the
manifest's own specification_type. Since the serialized top-level
mediaType derives from it, requesting OCI left the envelope as the base
image's docker v2s2 while config/layers became OCI -- a non-conformant
image: a docker v2s2 manifest referencing OCI layer media types
(application/vnd.oci.image.layer.v1.tar+gzip
8000
 and +zstd).

Strict OCI/distribution-spec tooling built on containers-image (skopeo,
podman, buildah) rejects this with "unsupported docker v2s2 media type";
the docker CLI is lenient and accepts it.

Spec: https://github.com/opencontainers/image-spec/blob/main/media-types.md
@bboe
bboe merged commit d688676 into main Jul 15, 2026
4 checks passed
@bboe
bboe deleted the fix/set-specification-type-manifest-envelope branch July 15, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0