Repository navigation
Conversation
non
enabled auto-merge (squash)
July 15, 2026 16:19
adam-singer
approved these changes
Jul 15, 2026
BillyAutrey
approved these changes
Jul 15, 2026
BillyAutrey
disabled auto-merge
July 15, 2026 17:13
BillyAutrey
enabled auto-merge (squash)
July 15, 2026 17:14
BillyAutrey
disabled auto-merge
July 15, 2026 17:19
`set_specification_type` retyped the config and each layer but not the manifest's own specification_type. Since the serialized top-level mediaType derives from it, requesting OCI left the envelope as the base image's docker v2s2 while config/layers became OCI -- a non-conformant image: a docker v2s2 manifest referencing OCI layer media types (application/vnd.oci.image.layer.v1.tar+gzip and +zstd). Strict OCI/distribution-spec tooling built on containers-image (skopeo, podman, buildah) rejects this with "unsupported docker v2s2 media type"; the docker CLI is lenient and accepts it. Spec: https://github.com/opencontainers/image-spec/blob/main/media-types.md
non
enabled auto-merge (squash)
July 15, 2026 17:21
Contributor
Author
|
Superseded by #648, opened from a branch hosted directly on bazeltools/rules_minidock_tools instead of my fork. |
auto-merge was automatically disabled
July 15, 2026 17:30
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_specification_type retyped the config and each layer but not the manifest's own specification_type. Since the serialized top-level mediaType derives from it, requesting OCI left the envelope as the base image's docker v2s2 while config/layers became OCI -- a non-conformant image: a docker v2s2 manifest referencing OCI layer media types (application/vnd.oci.image.layer.v1.tar+gzip and +zstd).
Strict OCI/distribution-spec tooling built on containers-image (skopeo, podman, buildah) rejects this with "unsupported docker v2s2 media type"; the docker CLI is lenient and accepts it.
Spec: https://github.com/opencontainers/image-spec/blob/main/media-types.md