8000 Retype the manifest envelope in set_specification_type by bboe · Pull Request #647 · bazeltools/rules_minidock_tools · GitHub
[go: up one dir, main page]

Skip to content

Retype the manifest envelope in set_specification_type - #647

Closed
bboe wants to merge 1 commit into
bazeltools:mainfrom
bboe:fix/set-specification-type-manifest-envelope
Closed

bboe wants to merge 1 commit into
bazeltools:mainfrom
bboe:fix/set-specification-type-manifest-envelope

Conversation

@bboe
@bboe bboe commented Jul 15, 2026
Copy link
Copy Markdown
Contributor

set_specification_type retyped the config and each layer but not the manifest's own specification_type. Since the serialized top-level mediaType derives from it, requesting OCI left the envelope as the base image's docker v2s2 while config/layers became OCI -- a non-conformant image: a docker v2s2 manifest referencing OCI layer media types (application/vnd.oci.image.layer.v1.tar+gzip and +zstd).

Strict OCI/distribution-spec tooling built on containers-image (skopeo, podman, buildah) rejects this with "unsupported docker v2s2 media type"; the docker CLI is lenient and accepts it.

Spec: https://github.com/opencontainers/image-spec/blob/main/media-types.md

@non
non enabled auto-merge (squash) July 15, 2026 16:19
@BillyAutrey
BillyAutrey disabled auto-merge July 15, 2026 17:13
@BillyAutrey
BillyAutrey enabled auto-merge (squash) July 15, 2026 17:14
@BillyAutrey
BillyAutrey disabled auto-merge July 15, 2026 17:19
`set_specification_type` retyped the config and each layer but not the
manifest's own specification_type. Since the serialized top-level
mediaType derives from it, requesting OCI left the envelope as the base
image's docker v2s2 while config/layers became OCI -- a non-conformant
image: a docker v2s2 manifest referencing OCI layer media types
(application/vnd.oci.image.layer.v1.tar+gzip and +zstd).

Strict OCI/distribution-spec tooling built on containers-image (skopeo,
podman, buildah) rejects this with "unsupported docker v2s2 media type";
the docker CLI is lenient and accepts it.

Spec: https://github.com/opencontainers/image-spec/blob/main/media-types.md
@non
non enabled auto-merge (squash) July 15, 2026 17:21
@bboe
bboe commented Jul 15, 2026
Copy link
Copy Markdown
Contributor Author

Superseded by #648, opened from a branch hosted directly on bazeltools/rules_minidock_tools instead of my fork.

@bboe bboe closed this Jul 15, 2026
auto-merge was automatically disabled July 15, 2026 17:30

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0