Repository navigation
CI: add a macos job (host tests + conformance) - #58
Merged
Merged
Conversation
The v0.12.0 release run on a Mac found two bugs Linux CI never saw (#57). Run the host tests and the conformance fixtures on macos-latest so the next one is caught before a release. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
…vate/var) The first macos CI run failed budget-roles: git reports the worktree as /private/var/... while the test built /var/.... Compare worktree paths by realpath there, and resolve layout.test.py's temp dir as git does. Reproduced locally with TMPDIR on a symlink; make test-hosts and make conformance pass that way. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
The macos CI job found that bash 3.2 does not abort on an unbound name inside $(( )) under set -u, so lock_recent read a bad date as a stale lock and the gate allowed the write. Treat a non-numeric date as a gate failure (exit 1, which the fail-closed trap turns into a block). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
The macos CI job showed the supervisor CLI never ran on a Mac: macOS has no `timeout`. Use timeout, then gtimeout, then perl's alarm (which survives exec). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
…dent [A-Z] On macOS, a UTF-8 collation makes [A-Z] match lowercase too, so the RED compile block offered `pub struct sub;` for a missing function and conformance §6.3 failed. Also print a failing conformance check's full block instead of 140 characters. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
adeelahmad
marked this pull request as ready for review
October 19, 2026 06:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before: CI ran only on Linux, so macOS-only bugs surfaced only on the owner's Mac release runs.
After: a
macosjob runsmake test-hostsandmake conformanceon macos-latest. Its first runs caught and this PR fixes:dateprinted a non-number (macOS/bin/bashdoes not abort on an unbound name inside$(( ))). It now exits 1 and the fail-closed trap blocks.[A-Z]*, which matches lowercase names in a macOS UTF-8 locale, so it suggestedpub struct sub;for a missing function. It now uses[[:upper:]]*.timeout, which macOS lacks. It now falls back togtimeout, then to a perl alarm./var/...with git's/private/var/....A failing conformance check now prints its full block.
How: Linux reproduces the path cases with
TMPDIRon a symlink.make cipasses locally, and all 5 CI jobs pass on f66cc3e.🤖 Generated with Claude Code
https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC