8000 CI: add a macos job (host tests + conformance) by adeelahmad · Pull Request #58 · adeelahmad/aloop · GitHub
[go: up one dir, main page]

Skip to content

CI: add a macos job (host tests + conformance) - #58

Merged
adeelahmad merged 5 commits into
masterfrom
claude/project-thread-qerfr9
Oct 19, 2026
Merged

adeelahmad merged 5 commits into
masterfrom
claude/project-thread-qerfr9

Conversation

@adeelahmad
@adeelahmad adeelahmad commented Oct 19, 2026 •
Copy link
Copy Markdown
Owner

Requested by Adeel · project thread

Before: CI ran only on Linux, so macOS-only bugs surfaced only on the owner's Mac release runs.

After: a macos job runs make test-hosts and make conformance on macos-latest. Its first runs caught and this PR fixes:

  • gate-supervisor-scope failed open on bash 3.2 when date printed a non-number (macOS /bin/bash does not abort on an unbound name inside $(( ))). It now exits 1 and the fail-closed trap blocks.
  • gate-red-verify used [A-Z]*, which matches lowercase names in a macOS UTF-8 locale, so it suggested pub struct sub; for a missing function. It now uses [[:upper:]]*.
  • e2e-live.sh relied on GNU timeout, which macOS lacks. It now falls back to gtimeout, then to a perl alarm.
  • Two tests compared /var/... with git's /private/var/....

A failing conformance check now prints its full block.

How: Linux reproduces the path cases with TMPDIR on a symlink. make ci passes locally, and all 5 CI jobs pass on f66cc3e.

🤖 Generated with Claude Code

https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC

The v0.12.0 release run on a Mac found two bugs Linux CI never saw
(#57). Run the host tests and the conformance fixtures on macos-latest
so the next one is caught before a release.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
…vate/var)

The first macos CI run failed budget-roles: git reports the worktree as
/private/var/... while the test built /var/.... Compare worktree paths by
realpath there, and resolve layout.test.py's temp dir as git does.
Reproduced locally with TMPDIR on a symlink; make test-hosts and
make conformance pass that way.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
The macos CI job found that bash 3.2 does not abort on an unbound name
inside $(( )) under set -u, so lock_recent read a bad date as a stale
lock and the gate allowed the write. Treat a non-numeric date as a gate
failure (exit 1, which the fail-closed trap turns into a block).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
The macos CI job showed the supervisor CLI never ran on a Mac: macOS has
no `timeout`. Use timeout, then gtimeout, then perl's alarm (which
survives exec).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
…dent [A-Z]

On macOS, a UTF-8 collation makes [A-Z] match lowercase too, so the RED
compile block offered `pub struct sub;` for a missing function and
conformance §6.3 failed. Also print a failing conformance check's full
block instead of 140 characters.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
@adeelahmad
adeelahmad marked this pull request as ready for review October 19, 2026 06:10
@adeelahmad
adeelahmad merged commit bce099d into master Oct 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0