Repository navigation
Fix two macOS-only bugs from the release run; record run 35 - #57
Merged
Merged
Conversation
- stats/budget compare story dirs by realpath (_paths.under): a project behind a symlink (macOS /var -> /private/var) counted 0 attempts in stats sprint-close; also stops sprint1 matching sprint10. - ensure-tools --resolve skips any aloop plugin bin/ on PATH: another checkout's ctx-symbols shim ahead on PATH made make conformance hang. Both reproduce on Linux in the updated tests. Run 35 is the first live run with a clean env (#56). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
adeelahmad
pushed a commit
that referenced
this pull request
Oct 19, 2026
The v0.12.0 release run on a Mac found two bugs Linux CI never saw (#57). Run the host tests and the conformance fixtures on macos-latest so the next one is caught before a release. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before: the release run on Adeel's Mac hit two bugs that Linux CI never sees.
budget-soft-telemetry.test.pyfailed.stats sprint-closecompared the realpathSTORY_DIRthatbudget contractrecords against the unresolved sprint dir. On macOS every temp dir is/var/..., a symlink to/private/var/..., so the comparison matched nothing and the sprint counted 0 attempts.make conformancehung when an older aloop checkout'splugin/binwas ahead on PATH.ensure-tools --resolve ctx-symbolsskipped only its own bin dir, so it returned that other checkout's shim. The shim's ownensure-toolsthen resolved back again.After:
statsand the sprint charge inbudgetcompare paths with a new_paths.under(), which uses realpath and a/-bounded prefix. As a side effect,sprint1no longer matchessprint10.find_toolskips any directory that holds anensure-tools, because that marks an aloop plugin bin whosemd-db/ctx-symbolsare only shims.How: both bugs reproduce on Linux in the updated tests.
budget-soft-telemetry.test.pynow runs its project through a symlink. It fails without the fix and passes with it.ensure-tools.test.pyputs a second checkout's shims ahead on PATH and asserts that--resolveskips them and finds the real binary behind them.ROADMAP M8 records both bugs and adds a "macOS CI job" as the next item, because both were found only by hand.
make ciis green.Also recorded: run 35 (wordfreq) is the first live run since #56 with a clean environment. It recalled no memory and had its own session id. It passed 13/13 in 12m59s for $0.91, with 31 supervisor turns, 2 wakes, 0 plugin-source reads and 2 blocks, both caught by the workers' own self-checks. Those numbers are within the range of runs 27–33.
Generated by Claude Code