8000 test: raise coverage to ≥90% and make CI coverage gate fatal at 90% by devin-ai-integration[bot] · Pull Request #106 · dominicusin/package-maximizer · GitHub
[go: up one dir, main page]
Skip to content

test: raise coverage to ≥90% and make CI coverage gate fatal at 90% #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dominicusin merged 2 commits into from
Oct 13, 2026
Merged

test: raise coverage to ≥90% and make CI coverage gate fatal at 90% #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1a1d49
test: raise coverage to >=90% and make CI gate fatal at 90%; fix TUI …
devin-ai-integration[bot] Oct 13, 2026
2490ba5
test: wait for TUI button label update instead of a single pause
devin-ai-integration[bot] Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ jobs:
# Fatals coverage gate only where all heavy solvers build (ubuntu).
# On macOS/Windows ortools/pysat cannot always compile, so their
# modules stay uncovered and a hard gate would always fail there.
COV_FAIL_UNDER: ${{ matrix.os == 'ubuntu-latest' && '85' || '' }}
COV_FAIL_UNDER: ${{ matrix.os == 'ubuntu-latest' && '90' || '' }}
shell: bash
run: |
GATE_FLAG=""
Expand Down
11 changes: 1 addition & 10 deletions package_maximizer/tui/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,7 @@ def dark_mode(self) -> bool:

def toggle_dark_mode(self) -> None:
self._dark_mode = not self._dark_mode
if self._dark_mode:
self.styles.background = "color: $boost"
self.query_one("#main").styles.background = "color: $surface"
self.query_one("#log").styles.background = "color: $surface"
else:
self.styles.background = "color: $surface"
self.query_one("#main").styles.background = None
self.query_one("#log").styles.background = None
self.set_class(self._dark_mode, "dark-mode")

def compose(self) -> ComposeResult:
yield Header()
Expand Down Expand Up @@ -143,8 +136,6 @@ def action_toggle_dark_mode(self) -> None:

def action_help(self) -> None:
"""Show help dialog via keyboard shortcut (Ctrl+H)."""
from textual.widgets import Footer

log = self.query_one("#log_output", Log)
log.write_line("")
log.write_line("=== HELP ===")
Expand Down
Loading
Loading
0