Repository navigation
test: raise coverage to ≥90% and make CI coverage gate fatal at 90% - #106
Merged
Merged
Conversation
…dark-mode crash Co-Authored-By: dominicusin <dominicusin@yahoo.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Documentation build overview
|
Co-Authored-By: dominicusin <dominicusin@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PROJECT_PLAN item: coverage ≥90% with a fatal gate.
.github/workflows/ci.yml: raisedCOV_FAIL_UNDERfrom85to90. As before, the gate runs only on ubuntu-latest, where every optional solver backend can be installed. A drop below 90% now fails the job.tests/test_coverage_gaps.py(35 tests) covers the CLI (maximize/propose --explain/info/history/shell),EnhancedGreedySolverconflict strategies,MaximizerShellcommands, TextualMaximizerAppactions, the web API (/api/v1/maximize|propose|analyze|compare, legacy/api/maximize,run_app()API-key branches) and the lazyPARSER_REGISTRYview.ColorParseError: failed to parse 'color:' as a color. The cause wastoggle_dark_mode()assigning invalid strings like"color: $boost"tostyles.background. It now toggles thedark-modeCSS class, whichMaximizerApp.CSSalready defines. Also removed an unusedFooterimport.Coverage measured locally on this branch:
Checks
pytest tests/ --cov=package_maximizer --cov-fail-under=90)Link to Devin session: https://app.devin.ai/sessions/7a195999dfd146d48fbc98f4bab6707a
Open in Devin Desktop: https://app.devin.ai/desktop/session/7a195999dfd146d48fbc98f4bab6707a?variant=devin
Requested by: @dominicusin