8000 python: warn people that they should look through the list of `optional-dependencies` by jfly · Pull Request #878 · nix-community/nix-init · GitHub
[go: up one dir, main page]
Skip to content

python: warn people that they should look through the list of optional-dependencies #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
figsoda merged 1 commit into from
Nov 4, 2026
Merged

python: warn people that they should look through the list of optional-dependencies #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/codegen/python.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ impl Builder for BuildPythonPackage {
.filter(|(_, deps)| !deps.is_empty());

if let Some((extra, deps)) = optional.next() {
writeln!(
out,
" # TODO: look through these dependency groups and remove unnecessary ones. For example, nixpkgs doesn't include test dependencies."
)?;
write!(out, " optional-dependencies = ")?;
if self.application {
write!(out, "with python3Packages; ")?;
Expand Down
1 change: 1 addition & 0 deletions tests/cmd/python-app.out/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ python3Packages.buildPythonApplication (finalAttrs: {
typing-extensions
];

# TODO: look through these dependency groups and remove unnecessary ones. For example, nixpkgs doesn't include test dependencies.
optional-dependencies = with python3Packages; {
colorama = [
colorama
Expand Down
1 change: 1 addition & 0 deletions tests/cmd/python-lib.out/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ buildPythonPackage (finalAttrs: {
markupsafe
];

# TODO: look through these dependency groups and remove unnecessary ones. For example, nixpkgs doesn't include test dependencies.
optional-dependencies = {
i18n = [
babel
Expand Down
1 change: 1 addition & 0 deletions tests/cmd/python-rust.out/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ buildPythonPackage (finalAttrs: {
typing-extensions
];

# TODO: look through these dependency groups and remove unnecessary ones. For example, nixpkgs doesn't include test dependencies.
optional-dependencies = {
docs = [
sphinx
Expand Down
Loading
0