Repository navigation
python: warn people that they should look through the list of optional-dependencies - #878
Conversation
| writeln!(out, " ];")?; | ||
|
|
||
| for (extra, deps) in optional { | ||
| // <<< TODO: link to justification, or if none exists, write up an explanation >>> |
There was a problem hiding this comment.
@SuperSandro2000, is there any documentation I can link to to justify this code?
145bbf9 to
2b51e00
Compare
|
CI failures seem to be about a bunch of unused python packages still getting added to the package arguments. Will require a little more logic to skip them. Marking this PR as draft for now. I'll fix this if folks think this is a correct change to make. |
|
@SuperSandro2000, WDYT? |
There was a problem hiding this comment.
I don't think it is that ready 😅 nox and sdist can probably be removed, too.
I think we need an interactive selection here otherwise this will become a never ending challenge
Honestly that seems like worse UX than just including everything and letting people remove unwanted groups in their preferred text editor (where they can look at things holistically, and use vcs+undo/redo, etc). How about a simple comment above the dependency groups that the user is expected to read and act upon? Something like "There are multiple dependency groups, look through them and remove unnecessary ones such as test, etc". |
|
Yeah, maybe the comment is the best. |
…al-dependencies` Based on feedback I received in NixOS/nixpkgs#559596 (comment)
2b51e00 to
124f16c
Compare
dev and test optional-dependenciesoptional-dependencies
Updated, PTAL! |
There was a problem hiding this comment.
some nixpkgs documentation on the convention would be nice
im also be open to having a preset ignore list alongside the comment
Based on feedback I received in
NixOS/nixpkgs#559596 (comment)