Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mashehu
force-pushed
the
use-git-to-trim-down-workflow-file-search
branch
from
November 5, 2026 10:41
f6b5adc to
a790247
Compare
mashehu
force-pushed
the
use-git-to-trim-down-workflow-file-search
branch
from
November 5, 2026 20:46
a790247 to
aa04daf
Compare
swastiktawate
approved these changes
Nov 6, 2026
There was a problem hiding this comment.
Smart fix, asking git itself which files are ignored is much more reliable than guessing with filename patterns. The test with a real git repo and nested ignore files is thorough. Two small things: the import subprocess sits inside the function rather than at the top of the file, is that on purpose? And the fallback only prunes folders when the pattern ends in *, so a pattern like *.log would not prune a folder. Is that covered anywhere?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.