8000 move `Path | str` to just `Path` and simplify downstream code by mashehu · Pull Request #4590 · nf-core/tools · GitHub
[go: up one dir, main page]
Skip to content

move Path | str to just Path and simplify downstream code - #4590

Open
mashehu wants to merge 11 commits into
nf-core:devfrom
mashehu:avoid-path-str-unions
Open

move Path | str to just Path and simplify downstream code#4590
mashehu wants to merge 11 commits into
nf-core:devfrom
mashehu:avoid-path-str-unions

Conversation

@mashehu
@mashehu mashehu commented Nov 4, 2026
Copy link
Copy Markdown
Member

No description provided.

@mashehu
mashehu requested a review from JulianFlesch November 4, 2026 15:39
@codecov
codecov Bot commented Nov 4, 2026 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.72%. Comparing base (623ccdc) to head (8e462ae).

Files with missing lines Patch % Lines
nf_core/modules/lint/meta_yml.py 75.00% 1 Missing ⚠️
nf_core/pipelines/create/create.py 87.50% 1 Missing ⚠️
nf_core/pipelines/create/utils.py 88.88% 1 Missing ⚠️
nf_core/pipelines/launch.py 83.33% 1 Missing ⚠️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JulianFlesch
JulianFlesch reviewed Nov 5, 2026
View reviewed changes
Comment thread nf_core/utils.py Resolved
JulianFlesch
JulianFlesch reviewed Nov 5, 2026
View reviewed changes
Comment thread nf_core/pipelines/create/create.py Resolved
@mashehu
mashehu force-pushed the avoid-path-str-unions branch from 94edbd3 to 98bb7fd Compare November 5, 2026 12:10
@mashehu mashehu mentioned this pull request Nov 5, 2026
Draft
@mashehu
mashehu requested a review from JulianFlesch November 5, 2026 13:37
@mashehu
mashehu force-pushed the avoid-path-str-unions branch from 98bb7fd to 8e462ae Compare November 6, 2026 21:20

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulianFlesch JulianFlesch Awaiting requested review from JulianFlesch

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mashehu @JulianFlesch
0