|
From: Stephen S. <rad...@gm...> - 2013-11-27 13:20:57
|
On Wed, Nov 27, 2013 at 2:05 PM, Stephen Sinclair <rad...@gm...> wrote:
> There could be ways to fix this using typedef'd structs instead of
> void pointers or something like that... I'm not sure whether such a
> change wouldn't have pretty bad implications for the API though. I'll
> look into it.
I'll just note that I'm experimenting with changing the typedefs in
lo_types.h from void* to struct{}*, and it's exposing a bunch more
similar mistakes.
I've always found the argument ordering in lo_send_message_from() to
be confusing. :(
For some reason I always expect these functions to be called
lo_message_send() and lo_message_send_from(), and take a lo_message as
first argument.. I get it wrong almost every time. We should
definitely try to get the compiler to flag these kind of mistakes, (if
it's possible without breaking everyone's code.)
Steve
|