[go: up one dir, main page]
Page MenuHomePhabricator
People rking

rking (Becca King)
User

Projects

User Details

User Since
Sep 29 2024, 4:28 PM (106 w, 5 d)
Availability
Available
Review Queue
0

Recent Activity
View All

Today

rking added a comment to D334695: Bug 2083072 - Update background of Your Rule section in VPN panel - r=#ip-protection-reviewers.

Figma:

YourRule.png (760×737 px, 70 KB)

Fri, Oct 16, 7:02 PM
rking created D334695: Bug 2083072 - Update background of Your Rule section in VPN panel - r=#ip-protection-reviewers.
Fri, Oct 16, 7:01 PM
rking closed D334311: Bug 2082660 - Land strings for holiday promo CFRs - r=#ip-protection-reviewers.
Fri, Oct 16, 6:57 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking committed rFIREFOXAUTOLANDd8c8f5ed3a0c: Bug 2082660 - Land strings for holiday promo CFRs - r=fluent-reviewers,bolsson (authored by rking).
Bug 2082660 - Land strings for holiday promo CFRs - r=fluent-reviewers,bolsson
Fri, Oct 16, 6:57 PM
rking added a comment to D334311: Bug 2082660 - Land strings for holiday promo CFRs - r=#ip-protection-reviewers.

Figma:

image.png (862×657 px, 167 KB)

Fri, Oct 16, 6:07 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking requested review of D334311: Bug 2082660 - Land strings for holiday promo CFRs - r=#ip-protection-reviewers.
Fri, Oct 16, 6:06 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking added a comment to D334673: WIP: Bug 2083043 - Swap in correct warning icon for delete error dialog in VPN site rules.

Screenshot:

image.png (260×660 px, 17 KB)

Fri, Oct 16, 6:04 PM
rking updated the test plan for D334673: WIP: Bug 2083043 - Swap in correct warning icon for delete error dialog in VPN site rules.
Fri, Oct 16, 6:03 PM
rking planned changes to D334673: WIP: Bug 2083043 - Swap in correct warning icon for delete error dialog in VPN site rules.
Fri, Oct 16, 6:00 PM
rking closed D334253: Bug 2082551 - Add new telemetry for inclusions count and rule_applied - r=#ip-protection-reviewers.
Fri, Oct 16, 3:28 AM · Restricted Project, testing-approved
rking committed rFIREFOXAUTOLAND001320c597b7: Bug 2082551 - Add new telemetry for inclusions count and rule_applied - r=ip… (authored by rking).
Bug 2082551 - Add new telemetry for inclusions count and rule_applied - r=ip…
Fri, Oct 16, 3:28 AM

Yesterday

rking updated the summary of D334325: Bug 2082582 - Post-Nova CSS Cleanup for Desktop VPN - r=#ip-protection-reviewers,kpatenio.
Thu, Oct 15, 9:48 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking created D334325: Bug 2082582 - Post-Nova CSS Cleanup for Desktop VPN - r=#ip-protection-reviewers,kpatenio.
Thu, Oct 15, 9:40 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking planned changes to D334311: Bug 2082660 - Land strings for holiday promo CFRs - r=#ip-protection-reviewers.
Thu, Oct 15, 9:01 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking edited projects for D334253: Bug 2082551 - Add new telemetry for inclusions count and rule_applied - r=#ip-protection-reviewers, added: Restricted Project; removed Restricted Project.
Thu, Oct 15, 8:50 PM · Restricted Project, testing-approved
rking updated the diff for D334253: Bug 2082551 - Add new telemetry for inclusions count and rule_applied - r=#ip-protection-reviewers.
Thu, Oct 15, 8:36 PM · Restricted Project, testing-approved
rking added a comment to D334281: Bug 2082477 - VPN is off for this site should only be displayed in the Your Rule section on excluded sites - r=#ip-protection-reviewers.

Implementation:

ExcludedSiteIconCorrected.png (590×505 px, 47 KB)

Thu, Oct 15, 8:08 PM · testing-approved
rking updated the diff for D334281: Bug 2082477 - VPN is off for this site should only be displayed in the Your Rule section on excluded sites - r=#ip-protection-reviewers.
Thu, Oct 15, 8:06 PM · testing-approved
rking added a comment to D334281: Bug 2082477 - VPN is off for this site should only be displayed in the Your Rule section on excluded sites - r=#ip-protection-reviewers.
Thu, Oct 15, 7:53 PM · testing-approved
rking created D334281: Bug 2082477 - VPN is off for this site should only be displayed in the Your Rule section on excluded sites - r=#ip-protection-reviewers.
Thu, Oct 15, 7:53 PM · testing-approved
rking added a comment to D334280: Bug 2082351 - VPN toolbar icon has incorrect UI when in overflow menu in included state - r=#ip-protection-reviewers.

LightModeIncludedIconOverflow.png (257×535 px, 29 KB)

Thu, Oct 15, 7:35 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking created D334280: Bug 2082351 - VPN toolbar icon has incorrect UI when in overflow menu in included state - r=#ip-protection-reviewers.
Thu, Oct 15, 7:34 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking created D334253: Bug 2082551 - Add new telemetry for inclusions count and rule_applied - r=#ip-protection-reviewers.
Thu, Oct 15, 6:03 PM · Restricted Project, testing-approved
rking closed D333724: Bug 2081805 - Remove unused locationButtonBadgeDismissed pref - r=#ip-protection-reviewers.
Thu, Oct 15, 4:20 PM · testing-exception-unchanged (Doesn't change behavior for users)
rking committed rFIREFOXAUTOLAND2c1e2bd0c963: Bug 2081805 - Remove unused locationButtonBadgeDismissed pref - r=ip-protection… (authored by rking).
Bug 2081805 - Remove unused locationButtonBadgeDismissed pref - r=ip-protection…
Thu, Oct 15, 4:20 PM
rking updated the diff for D334184: Bug 2082476 - Add confirmation hint when navigating to a site inclusion - r=#ip-protection-reviewers.
Thu, Oct 15, 3:56 PM · testing-approved
rking created D334184: Bug 2082476 - Add confirmation hint when navigating to a site inclusion - r=#ip-protection-reviewers.
Thu, Oct 15, 3:38 PM · testing-approved
rking closed D333704: Bug 2080900 - Add site rules onboarding message to VPN panel - r=#ip-protection-reviewers.
Thu, Oct 15, 3:26 PM · testing-approved
rking committed rFIREFOXAUTOLAND9dd91b9757d8: Bug 2080900 - Add site rules onboarding message to VPN panel - r=ip-protection… (authored by rking).
Bug 2080900 - Add site rules onboarding message to VPN panel - r=ip-protection…
Thu, Oct 15, 3:26 PM
rking closed D333717: Bug 2081785 - Editing a website rule to a duplicate URL should display a validation error - r=#ip-protection-reviewers.
Thu, Oct 15, 3:25 PM · testing-approved
rking committed rFIREFOXAUTOLAND3c8cbb75cbad: Bug 2081785 - Editing a website rule to a duplicate URL should display a… (authored by rking).
Bug 2081785 - Editing a website rule to a duplicate URL should display a…
Thu, Oct 15, 3:25 PM
rking closed D333418: Bug 2081374 - Create delete error dialog for VPN site rules - r=#ip-protection-reviewers.
Thu, Oct 15, 3:25 PM · testing-approved
rking committed rFIREFOXAUTOLAND12d31a4ce7e1: Bug 2081374 - Create delete error dialog for VPN site rules - r=ip-protection… (authored by rking).
Bug 2081374 - Create delete error dialog for VPN site rules - r=ip-protection…
Thu, Oct 15, 3:25 PM
rking edited projects for D334141: Bug 2081951 - Add telemetry for rules_page_opened - r=#ip-protection-reviewers, added: Restricted Project; removed Restricted Project.
Thu, Oct 15, 3:12 PM · Restricted Project, testing-approved
rking created D334141: Bug 2081951 - Add telemetry for rules_page_opened - r=#ip-protection-reviewers.
Thu, Oct 15, 2:06 PM · Restricted Project, testing-approved
rking updated the diff for D333717: Bug 2081785 - Editing a website rule to a duplicate URL should display a validation error - r=#ip-protection-reviewers.
Thu, Oct 15, 1:44 PM · testing-approved
rking added a comment to D333717: Bug 2081785 - Editing a website rule to a duplicate URL should display a validation error - r=#ip-protection-reviewers.

Screen grab:

Thu, Oct 15, 1:44 PM · testing-approved
rking added a comment to D333704: Bug 2080900 - Add site rules onboarding message to VPN panel - r=#ip-protection-reviewers.

Screenshot:

image.png (610×507 px, 50 KB)

Thu, Oct 15, 1:39 PM · testing-approved
rking updated the diff for D333704: Bug 2080900 - Add site rules onboarding message to VPN panel - r=#ip-protection-reviewers.
Thu, Oct 15, 1:39 PM · testing-approved
rking updated the diff for D333418: Bug 2081374 - Create delete error dialog for VPN site rules - r=#ip-protection-reviewers.
Thu, Oct 15, 1:33 PM · testing-approved
rking added a comment to D333418: Bug 2081374 - Create delete error dialog for VPN site rules - r=#ip-protection-reviewers.

Note: The Figma has an outline version of the warning icon, but this is the standard used elsewhere, so I've implemented what matches the rest of the design system.

Thu, Oct 15, 1:32 PM · testing-approved
rking closed D333888: Bug 2081815 - Update strings for site inclusions CFRs - r=#ip-protection-reviewers.
Thu, Oct 15, 2:21 AM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking committed rFIREFOXAUTOLANDe8097c7ae387: Bug 2081815 - Update strings for site inclusions CFRs - r=fluent-reviewers… (authored by rking).
Bug 2081815 - Update strings for site inclusions CFRs - r=fluent-reviewers…
Thu, Oct 15, 2:21 AM
rking closed D332939: Bug 2069153 - Add new copy mentioning site inclusions to signed out view of VPN settings - r=#ip-protection-reviewers.
Thu, Oct 15, 2:17 AM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking committed rFIREFOXAUTOLAND7fefb4e0ab3f: Bug 2069153 - Add new copy mentioning site inclusions to signed out view of VPN… (authored by rking).
Bug 2069153 - Add new copy mentioning site inclusions to signed out view of VPN…
Thu, Oct 15, 2:17 AM

Wed, Oct 14

rking updated the diff for D333888: Bug 2081815 - Update strings for site inclusions CFRs - r=#ip-protection-reviewers.
Wed, Oct 14, 9:45 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking updated the summary of D333888: Bug 2081815 - Update strings for site inclusions CFRs - r=#ip-protection-reviewers.
Wed, Oct 14, 9:16 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking created D333888: Bug 2081815 - Update strings for site inclusions CFRs - r=#ip-protection-reviewers.
Wed, Oct 14, 9:15 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking updated the diff for D332939: Bug 2069153 - Add new copy mentioning site inclusions to signed out view of VPN settings - r=#ip-protection-reviewers.
Wed, Oct 14, 8:45 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking requested review of D332939: Bug 2069153 - Add new copy mentioning site inclusions to signed out view of VPN settings - r=#ip-protection-reviewers.
Wed, Oct 14, 8:43 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking updated the diff for D333704: Bug 2080900 - Add site rules onboarding message to VPN panel - r=#ip-protection-reviewers.
Wed, Oct 14, 8:11 PM · testing-approved
rking created D333724: Bug 2081805 - Remove unused locationButtonBadgeDismissed pref - r=#ip-protection-reviewers.
Wed, Oct 14, 3:36 PM · testing-exception-unchanged (Doesn't change behavior for users)
rking accepted D332065: Bug 2074009 - Use isDefaultBrowserAsync() in IPProtectionPanel; r=#ip-protection-reviewers.
Wed, Oct 14, 3:28 PM · testing-approved
rking updated the test plan for D333717: Bug 2081785 - Editing a website rule to a duplicate URL should display a validation error - r=#ip-protection-reviewers.
Wed, Oct 14, 3:21 PM · testing-approved
rking created D333717: Bug 2081785 - Editing a website rule to a duplicate URL should display a validation error - r=#ip-protection-reviewers.
Wed, Oct 14, 3:18 PM · testing-approved
rking created D333704: Bug 2080900 - Add site rules onboarding message to VPN panel - r=#ip-protection-reviewers.
Wed, Oct 14, 2:59 PM · testing-approved
rking accepted D323324: Bug 2067288 - Retry IP Protection proxy pass rotation on wake instead of erroring out r?#ip-protection-reviewers.
Wed, Oct 14, 2:09 PM · testing-approved
rking added a comment to D332065: Bug 2074009 - Use isDefaultBrowserAsync() in IPProtectionPanel; r=#ip-protection-reviewers.

Looks good but needs a rebase so that I can pull it down to test it locally. Sorry for the delay on this!

Wed, Oct 14, 1:40 PM · testing-approved

Tue, Oct 13

rking closed D332897: Bug 2080356 - Fix perma failure in browser_privacy_ipprotection_siterules_srd.js - r=#ip-protection-reviewers.
Tue, Oct 13, 11:39 PM · testing-exception-unchanged (Doesn't change behavior for users)
rking committed rFIREFOXAUTOLAND84fa096f86e2: Bug 2080356 - Fix perma failure in browser_privacy_ipprotection_siterules_srd. (authored by rking).
Bug 2080356 - Fix perma failure in browser_privacy_ipprotection_siterules_srd.
Tue, Oct 13, 11:39 PM
rking updated the summary of D333418: Bug 2081374 - Create delete error dialog for VPN site rules - r=#ip-protection-reviewers.
Tue, Oct 13, 9:11 PM · testing-approved
rking created D333418: Bug 2081374 - Create delete error dialog for VPN site rules - r=#ip-protection-reviewers.
Tue, Oct 13, 9:03 PM · testing-approved
rking planned changes to D332939: Bug 2069153 - Add new copy mentioning site inclusions to signed out view of VPN settings - r=#ip-protection-reviewers.

Planning changes as we need to account for the holiday promo, during which there will be unlimited bandwidth. We will need versions of this copy for when the promo is live and site inclusions is not yet released, for when the promo is live and site inclusions has been released, and for when the promo is over and site inclusions is still active.

Tue, Oct 13, 5:37 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking closed D332923: Bug 2080891 - Remove New badge from location button - r=#ip-protection-reviewers.
Tue, Oct 13, 5:14 PM · testing-approved
rking committed rFIREFOXAUTOLAND43b12ee5f7ca: Bug 2080891 - Remove New badge from location button - r=ip-protection-reviewers… (authored by rking).
Bug 2080891 - Remove New badge from location button - r=ip-protection-reviewers…
Tue, Oct 13, 5:14 PM
rking added inline comments to D332939: Bug 2069153 - Add new copy mentioning site inclusions to signed out view of VPN settings - r=#ip-protection-reviewers.
Tue, Oct 13, 3:37 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking updated the diff for D332939: Bug 2069153 - Add new copy mentioning site inclusions to signed out view of VPN settings - r=#ip-protection-reviewers.
Tue, Oct 13, 3:36 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)

Mon, Oct 12

rking created D332939: Bug 2069153 - Add new copy mentioning site inclusions to signed out view of VPN settings - r=#ip-protection-reviewers.
Mon, Oct 12, 4:01 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking created D332923: Bug 2080891 - Remove New badge from location button - r=#ip-protection-reviewers.
Mon, Oct 12, 3:20 PM · testing-approved
rking accepted D332877: Bug 2079752 - Only count the toggle's own mode as protection being on in the panel r?#ip-protection-reviewers.
Mon, Oct 12, 2:45 PM · testing-approved
rking accepted D328890: Bug 2066842 - Keep always-on sites covered through IPPAutoActivation r?#ip-protection-reviewers.

r+ but needs to be landed with child revision

Mon, Oct 12, 2:45 PM · testing-approved
rking accepted D328908: Bug 2068770 - Fetch the server list once startup has completed instead of mirroring it into a pref r?#ip-protection-reviewers.

Looks good, thanks!

Mon, Oct 12, 2:42 PM · testing-approved
rking updated the summary of D332897: Bug 2080356 - Fix perma failure in browser_privacy_ipprotection_siterules_srd.js - r=#ip-protection-reviewers.
Mon, Oct 12, 2:16 PM · testing-exception-unchanged (Doesn't change behavior for users)
rking created D332897: Bug 2080356 - Fix perma failure in browser_privacy_ipprotection_siterules_srd.js - r=#ip-protection-reviewers.
Mon, Oct 12, 2:15 PM · testing-exception-unchanged (Doesn't change behavior for users)

Fri, Oct 9

rking closed D329030: Bug 2074574 - Add dialog for creating a site inclusion or exclusion rule in VPN settings - r=#ip-protection-reviewers.
Fri, Oct 9, 5:37 PM · testing-approved
rking closed D329985: Bug 2075355 - Add a dialog for editing a site inclusion or exclusion - r=#ip-protection-reviewers,kpatenio.
Fri, Oct 9, 5:37 PM · testing-approved
rking closed D331293: Bug 2074578 - Create delete confirmation dialogs for VPN site rules settings - r=#ip-protection-reviewers,kpatenio,mstriemer.
Fri, Oct 9, 5:37 PM · testing-approved
rking closed D328232: Bug 2074514 - Create new list component for managing site permissions in website settings subpane - r=#ip-protection-reviewers.
Fri, Oct 9, 5:37 PM · testing-approved
rking committed rFIREFOXAUTOLANDba1f25b133b8: Bug 2074578 - Create delete confirmation dialogs for VPN site rules settings… (authored by rking).
Bug 2074578 - Create delete confirmation dialogs for VPN site rules settings…
Fri, Oct 9, 5:37 PM
rking committed rFIREFOXAUTOLAND28f4a840c244: Bug 2075355 - Add a dialog for editing a site inclusion or exclusion… (authored by rking).
Bug 2075355 - Add a dialog for editing a site inclusion or exclusion…
Fri, Oct 9, 5:37 PM
rking committed rFIREFOXAUTOLANDf979e4a84ee5: Bug 2074514 - Create new list component for managing site permissions in… (authored by rking).
Bug 2074514 - Create new list component for managing site permissions in…
Fri, Oct 9, 5:37 PM
rking committed rFIREFOXAUTOLAND3799afe3436d: Bug 2074574 - Add dialog for creating a site inclusion or exclusion rule in VPN… (authored by rking).
Bug 2074574 - Add dialog for creating a site inclusion or exclusion rule in VPN…
Fri, Oct 9, 5:37 PM
rking updated the diff for D331293: Bug 2074578 - Create delete confirmation dialogs for VPN site rules settings - r=#ip-protection-reviewers,kpatenio,mstriemer.
Fri, Oct 9, 4:22 PM · testing-approved
rking updated the diff for D329985: Bug 2075355 - Add a dialog for editing a site inclusion or exclusion - r=#ip-protection-reviewers,kpatenio.
Fri, Oct 9, 4:22 PM · testing-approved
rking updated the diff for D329030: Bug 2074574 - Add dialog for creating a site inclusion or exclusion rule in VPN settings - r=#ip-protection-reviewers.
Fri, Oct 9, 4:22 PM · testing-approved
rking updated the diff for D328232: Bug 2074514 - Create new list component for managing site permissions in website settings subpane - r=#ip-protection-reviewers.
Fri, Oct 9, 4:22 PM · testing-approved
rking updated the uplift request field for D332408: Bug 2078192 - Focus ring around Settings button is clipped during keyboard navigation when in paused or error state -.
Fri, Oct 9, 1:10 PM
rking created D332408: Bug 2078192 - Focus ring around Settings button is clipped during keyboard navigation when in paused or error state -.
Fri, Oct 9, 1:09 PM

Thu, Oct 8

rking closed D331293: Bug 2074578 - Create delete confirmation dialogs for VPN site rules settings - r=#ip-protection-reviewers,kpatenio,mstriemer.
Thu, Oct 8, 10:44 PM · testing-approved
rking closed D329985: Bug 2075355 - Add a dialog for editing a site inclusion or exclusion - r=#ip-protection-reviewers,kpatenio.
Thu, Oct 8, 10:44 PM · testing-approved
rking committed rFIREFOXAUTOLAND37865ff75105: Bug 2074578 - Create delete confirmation dialogs for VPN site rules settings… (authored by rking).
Bug 2074578 - Create delete confirmation dialogs for VPN site rules settings…
Thu, Oct 8, 10:44 PM
rking committed rFIREFOXAUTOLAND4ebc6be645df: Bug 2075355 - Add a dialog for editing a site inclusion or exclusion… (authored by rking).
Bug 2075355 - Add a dialog for editing a site inclusion or exclusion…
Thu, Oct 8, 10:44 PM
rking closed D329030: Bug 2074574 - Add dialog for creating a site inclusion or exclusion rule in VPN settings - r=#ip-protection-reviewers.
Thu, Oct 8, 10:44 PM · testing-approved
rking committed rFIREFOXAUTOLAND5aaebbd742b2: Bug 2074574 - Add dialog for creating a site inclusion or exclusion rule in VPN… (authored by rking).
Bug 2074574 - Add dialog for creating a site inclusion or exclusion rule in VPN…
Thu, Oct 8, 10:44 PM
rking closed D328232: Bug 2074514 - Create new list component for managing site permissions in website settings subpane - r=#ip-protection-reviewers.
Thu, Oct 8, 10:44 PM · testing-approved
rking committed rFIREFOXAUTOLAND666fdefcaa0c: Bug 2074514 - Create new list component for managing site permissions in… (authored by rking).
Bug 2074514 - Create new list component for managing site permissions in…
Thu, Oct 8, 10:44 PM
rking closed D331424: Bug 2078192 - Focus ring around Settings button is clipped during keyboard navigation when in paused or error state - r=#ip-protection-reviewers.
Thu, Oct 8, 8:37 PM · testing-exception-ui (Only changes ui styling, images, or localized strings)
rking committed rFIREFOXAUTOLAND70818f141239: Bug 2078192 - Focus ring around Settings button is clipped during keyboard… (authored by rking).
Bug 2078192 - Focus ring around Settings button is clipped during keyboard…
Thu, Oct 8, 8:37 PM
rking closed D331738: Bug 2078236 - The VPN panel is not dismissed after clicking the Learn more link in the local region error view - r=#ip-protection-reviewers.
Thu, Oct 8, 8:36 PM · testing-approved
rking committed rFIREFOXAUTOLAND776ab119f374: Bug 2078236 - The VPN panel is not dismissed after clicking the Learn more link… (authored by rking).
Bug 2078236 - The VPN panel is not dismissed after clicking the Learn more link…
Thu, Oct 8, 8:36 PM
Privacy · Cookies · Legal