[go: up one dir, main page]
Page MenuHomePhabricator
Differential D334063

Bug 2051240 - Avoid repeated layout calculations for nested margin trimming. r?#layout-reviewers
Needs ReviewPublic
Actions

Authored by tlouw on Thu, Oct 15, 11:36 AM.

Details

Reviewers
None
Group Reviewers
layout-reviewers
Bugzilla Bug ID
2051240
Merge Conflict Status
Landing merges cleanly into the target branch
Merges cleanly when merged against target branch tip 6210f73af7ef, starting from 64cfaf34e56f, with 5 parent revision(s) applied first.
Last checked Fri, Oct 16, 9:25 PM
Diff 1407436, based on 64cfaf34e56f

Diff Detail

Repository
rFIREFOXAUTOLAND firefox-autoland
Branch
HEAD

Event Timeline

tlouw created this revision.Thu, Oct 15, 11:36 AM
Herald added a project: secure-revision. · View Herald TranscriptThu, Oct 15, 11:36 AM
phab-bot published this revision for review.Thu, Oct 15, 11:38 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added subscribers: zrhoffman, emilio. · View Herald TranscriptThu, Oct 15, 11:38 AM
emilio added a comment.Thu, Oct 15, 11:55 AM

Can you elaborate on the commit message why do we need this?

reviewbot added a project: testing-approved.Thu, Oct 15, 12:02 PM
Harbormaster completed remote builds in B1065307: Diff 1407436.Thu, Oct 15, 12:02 PM
dshin added a subscriber: dshin.Thu, Oct 15, 5:37 PM
dshin added inline comments.
layout/generic/nsBlockFrame.h
608

I can see the justification, but I do wonder if the amount of machinery being added, and the logic involved, is worth it.

Do we have a perf baseline vs. optimized comparison? If so, would be nice to have, but since this is a new feature, we don't know what the usage out there will be like.
... In which case, maybe this is worth landing later if we see issues?

Revision Contents
Changeset List

PathSize
layout/
generic/
4 lines
7 lines
2 lines
9 lines
85 lines
testing/
web-platform/
tests/
css/
css-box/
margin-trim/
135 lines

Diff 1407436

View Options

layout/generic/BlockReflowState.h

Loading...
View Options

layout/generic/ReflowInput.h

Loading...
View Options

layout/generic/ReflowInput.cpp

Loading...
View Options

layout/generic/nsBlockFrame.h

Loading...
View Options

layout/generic/nsBlockFrame.cpp

Loading...
View Options

testing/web-platform/tests/css/css-box/margin-trim/block-container-block-end-deep-dynamic.html

Loading...
Privacy · Cookies · Legal