[go: up one dir, main page]
Page MenuHomePhabricator
Differential D326709

Bug 2068761 - Start creating private Kinds for specialized microtasks r?arai
ClosedPublic
Actions

Authored by mgaudet on Sep 16 2026, 7:22 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Oct 15, 8:26 AM
Unknown Object (File)
Thu, Oct 15, 8:26 AM
Unknown Object (File)
Tue, Oct 13, 2:22 PM
Unknown Object (File)
Sun, Oct 11, 12:11 PM
Unknown Object (File)
Sat, Oct 10, 7:08 PM
Unknown Object (File)
Wed, Oct 7, 6:40 AM
Unknown Object (File)
Wed, Oct 7, 5:18 AM
Unknown Object (File)
Wed, Oct 7, 4:28 AM
View All 28 Files
Subscribers
None

Details

Reviewers
arai
Commits
rFIREFOXAUTOLAND3c7aefc6651b: Bug 2068761 - Start creating private Kinds for specialized microtasks r=arai
Bugzilla Bug ID
2068761
Summary

Since embedders only care about isJS() vs isEmbedder() we begin to
be able to carve out space for engine specialization.

The current patch allocates a range of 16 as I believe that will be sufficient
for the final state.

This commit also forces EnqueueJob callers to declare the kind of job, which
is preparation for alternative task shapes

Diff Detail

Event Timeline

mgaudet created this revision.Sep 16 2026, 7:22 PM
Herald added a project: secure-revision. · View Herald TranscriptSep 16 2026, 7:22 PM
mgaudet added a child revision: D326710: Bug 2068761 - Dispatch JS microtasks on their element kind r?arai.Sep 16 2026, 7:22 PM
phab-bot published this revision for review.Sep 16 2026, 7:22 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Harbormaster completed remote builds in B1045647: Diff 1378809.Sep 16 2026, 7:48 PM
mgaudet updated this revision to Diff 1378849.Wed, Sep 16, 8:02 PM
Harbormaster completed remote builds in B1045687: Diff 1378849.Wed, Sep 16, 8:32 PM
arai accepted this revision.Fri, Sep 18, 10:01 AM
arai added a project: testing-exception-unchanged (Doesn't change behavior for users).
arai added inline comments.
js/src/builtin/Promise.cpp
1674

What's the reason why this is a template parameter, instead of a regular value parameter?
Does instantiation per each kind help performance or something?

This revision is now accepted and ready to land.Fri, Sep 18, 10:01 AM
mgaudet updated this revision to Diff 1388180.Thu, Sep 24, 6:29 PM
mgaudet edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B1052026: Diff 1388180.Thu, Sep 24, 6:53 PM
mgaudet updated this revision to Diff 1389641.Fri, Sep 25, 9:44 PM
mgaudet updated this revision to Diff 1389656.Fri, Sep 25, 9:52 PM
Harbormaster failed remote builds in B1053002: Diff 1389641!Fri, Sep 25, 9:57 PM
Harbormaster completed remote builds in B1053015: Diff 1389656.Fri, Sep 25, 10:14 PM
mgaudet marked an inline comment as done.Tue, Sep 29, 8:40 PM
mgaudet updated this revision to Diff 1391821.Tue, Sep 29, 8:43 PM
Harbormaster completed remote builds in B1054494: Diff 1391821.Tue, Sep 29, 9:00 PM
mgaudet updated this revision to Diff 1394123.Fri, Oct 2, 8:10 PM
This revision was landed with ongoing or failed builds.Fri, Oct 2, 8:17 PM
Closed by commit rFIREFOXAUTOLAND3c7aefc6651b: Bug 2068761 - Start creating private Kinds for specialized microtasks r=arai (authored by mgaudet). · Explain Why
This revision was automatically updated to reflect the committed changes.
mgaudet added a commit: rFIREFOXAUTOLAND3c7aefc6651b: Bug 2068761 - Start creating private Kinds for specialized microtasks r=arai.
Harbormaster completed remote builds in B1055975: Diff 1394123.Fri, Oct 2, 8:33 PM
mgaudet mentioned this in rFIREFOXBETA3c7aefc6651b: Bug 2068761 - Start creating private Kinds for specialized microtasks r=arai.Thu, Oct 8, 3:03 PM

Revision Contents
Changeset List

PathSize
js/
public/
friend/
22 lines
src/
builtin/
30 lines
vm/
48 lines
13 lines

Diff 1394129

View Options

js/public/friend/MicroTask.h

Loading...
View Options

js/src/builtin/Promise.cpp

Loading...
View Options

js/src/vm/JSContext.h

Loading...
View Options

js/src/vm/JSContext.cpp

Loading...
Privacy · Cookies · Legal