This a follow up to Bug 2063576 adding tests for 2042996 since the previous bug already solved this issue internally itself
Details
Details
- Reviewers
arai - Commits
- rFIREFOXAUTOLAND70704187993f: Bug 2042996 - Add tests for disposal vs iterator.return() errors during…
- Bugzilla Bug ID
- 2042996
Diff Detail
Diff Detail
- Repository
- rFIREFOXAUTOLAND firefox-autoland
Event Timeline
Comment Actions
Rebase onto latest main; drop landed 2040286; 2042996 is tests-only after 2063576; fix async IteratorClose throw-completion
This comment was removed by debadree333.
Comment Actions
Simplify tests: drop comments, share sync/async helpers, remove redundant break case.
Comment Actions
Hello arai this patch simply adds tests for the bug, the bug was autofixed by the other bug bugzilla.mozilla.org/show_bug.cgi?id=2063576
The remaining patch stack i am slowly working through to resolve the remaining issues and transform to the static disposal idea
Comment Actions
I tried submitting to try but there seems to be some issue:
➜ mozilla-unified git:(explicit-resource-management-enhancements-and-fixes) ✗ ./mach try --preset sm-shell Pushing to try... Using 9e4ba5f8a056a91000b369dd508c1e438e3a2192 as the git base commit. Submitting stack of 7 nodes and the try commit. abort: error submitting patches to Lando. Missing permissions: main.scm_level_1
Comment Actions
Please remove "WIP:" prefix from the commit message.
it's automatically added when you submit with wip status, and it's not automatically removed if you convert it to "needs review" from the web interface.
You can remove it from "Edit Revision" link in the side bar.
For the try submission issue, it might be caused by the account you're using. There was recent change and I think now it requires LDAP account, not Firefox Account.
~/.mozbuild/lando_auth0_user_token.json file contains the current auth information (WARNING: do not disclose the content of the file),
you can check which account is used there.
If it looks using different account, or you're not sure, you can remove the file to reset it, so that you can perform the auth in the browser again.
Also, you can check if your account still has the access, by SSH-ing to hgmo (after setting up the SSH key):
ssh hg.mozilla.org
if it shows you have scm_level_1, then it could be the Lando's side issue, or maybe a temporary issue. You can ask in the Conduit room in Matrix.
If it shows you don't have scm_level_1, then it might have been expired for some reason. You could file a bug to re-activate it.
Comment Actions
Hello arai! Have removed the wip, I checked on ssh hg.mozilla.org and seems like i have the permission it says:
You are a member of the following LDAP groups that govern source control access: scm_level_1
I have asked in the conduit channel, in the meantime would you be able to push to try? or if it looks ok maybe we can land!
Thank you!!
Comment Actions
Thank you for investigation!
Here's try run, and it looks green:
https://treeherder.mozilla.org/jobs?repo=try&revision=895efe232af3390b2bc2b93197193106081fd03d