debadree333 retitled this revision from WIP: Bug 2040286 - Treat using bindings as non-writable like const. to Bug 2040286 - Treat using bindings as non-writable like const. r=arai.

debadree333 added a reviewer: arai.

This comment was removed by debadree333.

Hello arai!

Hope you are doing well, I apologise for being away for so long and leaving this bugs, this patch solves 2040286 almost same according to how the bug's description states + added tests, I was thinking if for checks like

bi.kind() == BindingKind::Const || bi.kind() == BindingKind::Using)

we should have some helper function like isConstLike() or maybe that would be a overkill?

Thank you!

Harbormaster completed remote builds in B1023812: Diff 1349028.Aug 15 2026, 3:38 PM

Harbormaster completed remote builds in B1023820: Diff 1349036.Aug 15 2026, 3:42 PM

Looks good!

In D315807#11073474, @debadree333 wrote:

I was thinking if for checks like

bi.kind() == BindingKind::Const || bi.kind() == BindingKind::Using)
we should have some helper function like isConstLike() or maybe that would be a overkill?

For the current consumers, it's not necessary, but if we have more similar consumers, it would be nice to add some helper method.

Have you already pushed the patch to try? If so, please post the URL of the try.
I'll land the patch once the green try run is confirmed.

Thanks!

This revision is now accepted and ready to land.Aug 18 2026, 12:04 AM

Rebase onto latest main

Hello arai!

The try run https://treeherder.mozilla.org/jobs?repo=try&revision=e4d5cd02a4bdb625fc5c9a39abb4eea318c6ad39

Harbormaster completed remote builds in B1025943: Diff 1351957.Aug 19 2026, 9:21 AM

Try is green \o/

Closed by commit rFIREFOXAUTOLANDfc9d369df353: Bug 2040286 - Treat using bindings as non-writable like const. r=arai (authored by debadree333, committed by arai_a@mac.com <arai_a@mac.com>). · Explain WhyAug 19 2026, 1:18 PM

This revision was automatically updated to reflect the committed changes.

arai_a@mac.com <arai_a@mac.com> added a commit: rFIREFOXAUTOLANDfc9d369df353: Bug 2040286 - Treat using bindings as non-writable like const. r=arai.

debadree333 removed a child revision: D315809: WIP: Bug 2042291 - Close for-of iterators when head resource disposal throws..Aug 24 2026, 5:34 PM

arai_a@mac.com <arai_a@mac.com> mentioned this in rFIREFOXBETAfc9d369df353: Bug 2040286 - Treat using bindings as non-writable like const. r=arai.Aug 27 2026, 1:45 PM

arai_a@mac.com <arai_a@mac.com> mentioned this in rFIREFOXRELEASEfc9d369df353: Bug 2040286 - Treat using bindings as non-writable like const. r=arai.Sep 9 2026, 5:41 PM

Bug 2040286 - Treat using bindings as non-writable like const. r=arai
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 1352200

js/src/frontend/Parser.cpp

js/src/jit-test/tests/debug/Environment-setVariable-using.js

js/src/jit-test/tests/explicit-resource-management/using-not-writable-in-eval.js

js/src/vm/EnvironmentObject.cpp

js/src/vm/Scope.cpp

Bug 2040286 - Treat using bindings as non-writable like const. r=araiClosedPublicActions