[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T379094

TypeError: Argument 1 passed to MediaWiki\Extension\CommunityConfiguration\Provider\AbstractProvider::normalizeTopLevelConfigData() must be an instance of stdClass, array given, called in /srv/mediawiki/php-1.44.0-wmf.1/extensi
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to MediaWiki\Extension\CommunityConfiguration\Provider\AbstractProvider::normalizeTopLevelConfigData() must be an instance of stdClass, array given, called in /srv/mediawiki/php-1.44.0-wmf.1/extensi
FrameLocationCall
from/srv/mediawiki/php-1.44.0-wmf.1/extensions/CommunityConfiguration/src/Provider/AbstractProvider.php(148)
#0/srv/mediawiki/php-1.44.0-wmf.1/extensions/CommunityConfiguration/src/Provider/AbstractProvider.php(104)MediaWiki\Extension\CommunityConfiguration\Provider\AbstractProvider->normalizeTopLevelConfigData(array)
#1/srv/mediawiki/php-1.44.0-wmf.1/extensions/CommunityConfiguration/src/Provider/AbstractProvider.php(145)MediaWiki\Extension\CommunityConfiguration\Provider\AbstractProvider->doStoreValidConfiguration(array, MediaWiki\User\User, string, bool)
#2/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/includes/Mentorship/Provider/CommunityStructuredMentorWriter.php(37)MediaWiki\Extension\CommunityConfiguration\Provider\AbstractProvider->alwaysStoreValidConfiguration(array, MediaWiki\User\User, string)
#3/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/includes/Mentorship/Provider/AbstractStructuredMentorWriter.php(116)GrowthExperiments\Mentorship\Provider\CommunityStructuredMentorWriter->doSaveMentorData(array, string, MediaWiki\User\User, bool)
#4/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/includes/Mentorship/Provider/AbstractStructuredMentorWriter.php(186)GrowthExperiments\Mentorship\Provider\AbstractStructuredMentorWriter->saveMentorData(array, string, MediaWiki\User\User, bool)
#5/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/includes/Mentorship/MentorRemover.php(46)GrowthExperiments\Mentorship\Provider\AbstractStructuredMentorWriter->removeMentor(GrowthExperiments\Mentorship\Mentor, MediaWiki\User\User, string)
#6/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/includes/Specials/Forms/ManageMentorsRemoveMentor.php(63)GrowthExperiments\Mentorship\MentorRemover->removeMentor(MediaWiki\User\User, MediaWiki\User\UserIdentityValue, string, MediaWiki\Context\RequestContext)
#7[internal function]GrowthExperiments\Specials\Forms\ManageMentorsRemoveMentor->onSubmit(array, GrowthExperiments\Specials\Forms\ManageMentorsRemoveMentor)
#8/srv/mediawiki/php-1.44.0-wmf.1/includes/htmlform/HTMLForm.php(822)call_user_func(array, array, GrowthExperiments\Specials\Forms\ManageMentorsRemoveMentor)
#9/srv/mediawiki/php-1.44.0-wmf.1/includes/htmlform/HTMLForm.php(703)MediaWiki\HTMLForm\HTMLForm->trySubmit()
#10/srv/mediawiki/php-1.44.0-wmf.1/includes/htmlform/HTMLForm.php(719)MediaWiki\HTMLForm\HTMLForm->tryAuthorizedSubmit()
#11/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/includes/Specials/Forms/ManageMentorsAbstractForm.php(85)MediaWiki\HTMLForm\HTMLForm->show()
#12/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/includes/Specials/SpecialManageMentors.php(424)GrowthExperiments\Specials\Forms\ManageMentorsAbstractForm->show()
#13/srv/mediawiki/php-1.44.0-wmf.1/extensions/GrowthExperiments/includes/Specials/SpecialManageMentors.php(499)GrowthExperiments\Specials\SpecialManageMentors->handleAction(string)
#14/srv/mediawiki/php-1.44.0-wmf.1/includes/specialpage/SpecialPage.php(728)GrowthExperiments\Specials\SpecialManageMentors->execute(string)
#15/srv/mediawiki/php-1.44.0-wmf.1/includes/specialpage/SpecialPageFactory.php(1726)MediaWiki\SpecialPage\SpecialPage->run(string)
#16/srv/mediawiki/php-1.44.0-wmf.1/includes/actions/ActionEntryPoint.php(504)MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#17/srv/mediawiki/php-1.44.0-wmf.1/includes/actions/ActionEntryPoint.php(146)MediaWiki\Actions\ActionEntryPoint->performRequest()
#18/srv/mediawiki/php-1.44.0-wmf.1/includes/MediaWikiEntryPoint.php(200)MediaWiki\Actions\ActionEntryPoint->execute()
#19/srv/mediawiki/php-1.44.0-wmf.1/index.php(58)MediaWiki\MediaWikiEntryPoint->run()
#20/srv/mediawiki/w/index.php(3)require(string)
#21{main}
Impact

It is not possible to remove mentors via Special:ManageMentors.

Notes

Reported by a Czech Wikipedia admin who was attempting to make a removal.

Details

Request URL
https://cs.wikipedia.org/wiki/Speci%C3%A1ln%C3%AD:Spravovat_mentory/remove-mentor/*
SubjectRepoBranchLines +/-
AbstractProvider: Normalize top level config correctlymediawiki/extensions/CommunityConfigurationwmf/1.44.0-wmf.2+2 -1
AbstractProvider: Normalize top level config correctlymediawiki/extensions/CommunityConfigurationwmf/1.44.0-wmf.1+2 -1
[tests] Mentorship: Test with CommunityConfigurationmediawiki/extensions/GrowthExperimentsmaster+14 -0
AbstractProvider: Normalize top level config correctlymediawiki/extensions/CommunityConfigurationmaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm_WMF created this task.Tue, Nov 5, 4:21 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptTue, Nov 5, 4:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Urbanecm_WMF added a comment.Tue, Nov 5, 4:22 PM

According to the error message, this appears to be somehow related to T369608: Create a reasonable solution for working with CommunityConfiguration data.

gerritbot added a comment.Tue, Nov 5, 4:41 PM

Change #1087516 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] AbstractProvider: Normalize top level config correctly

https://gerrit.wikimedia.org/r/1087516

gerritbot added a project: Patch-For-Review.Tue, Nov 5, 4:41 PM
Urbanecm_WMF claimed this task.Tue, Nov 5, 4:42 PM
Urbanecm_WMF triaged this task as High priority.
Urbanecm_WMF edited projects, added Growth-Team (Current Sprint), MediaWiki-extensions-CommunityConfiguration; removed Growth-Team.

The testsuite for SpecialManageMentors fails locally with the very same error. It does not fail in CI, because T369709: Switch `GEUseCommunityConfigurationExtension` to `true` in extension.json and fix tests failing in CI is not done. Fix is easy, uploaded a patch, moving to sprint and Code Review.

Michael mentioned this in T379095: CommunityConfiguration merges are blocked by a composer dependency mismatch.Tue, Nov 5, 4:50 PM
gerritbot added a comment.Tue, Nov 5, 4:50 PM

Change #1087520 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [tests] Mentorship: Test with CommunityConfiguration

https://gerrit.wikimedia.org/r/1087520

Urbanecm_WMF mentioned this in T369709: Switch `GEUseCommunityConfigurationExtension` to `true` in extension.json and fix tests failing in CI.Tue, Nov 5, 4:50 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.Tue, Nov 5, 6:02 PM
gerritbot added a comment.Tue, Nov 5, 6:56 PM

Change #1087516 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] AbstractProvider: Normalize top level config correctly

https://gerrit.wikimedia.org/r/1087516

Urbanecm mentioned this in rECOM5b32c97d1150: AbstractProvider: Normalize top level config correctly.Tue, Nov 5, 6:57 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Tue, Nov 5, 7:00 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Tue, Nov 5, 7:03 PM
gerritbot added a comment.Tue, Nov 5, 7:25 PM

Change #1087520 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] [tests] Mentorship: Test with CommunityConfiguration

https://gerrit.wikimedia.org/r/1087520

Maintenance_bot removed a project: Patch-For-Review.Tue, Nov 5, 7:31 PM
gerritbot added a comment.Tue, Nov 5, 7:39 PM

Change #1087560 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@wmf/1.44.0-wmf.1] AbstractProvider: Normalize top level config correctly

https://gerrit.wikimedia.org/r/1087560

gerritbot added a project: Patch-For-Review.Tue, Nov 5, 7:39 PM

Change #1087561 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@wmf/1.44.0-wmf.2] AbstractProvider: Normalize top level config correctly

https://gerrit.wikimedia.org/r/1087561

gerritbot added a comment.Tue, Nov 5, 9:13 PM

Change #1087560 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@wmf/1.44.0-wmf.1] AbstractProvider: Normalize top level config correctly

https://gerrit.wikimedia.org/r/1087560

gerritbot added a comment.Tue, Nov 5, 9:13 PM

Change #1087561 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@wmf/1.44.0-wmf.2] AbstractProvider: Normalize top level config correctly

https://gerrit.wikimedia.org/r/1087561

Urbanecm mentioned this in rECOM9d6f97210d82: AbstractProvider: Normalize top level config correctly.Tue, Nov 5, 9:15 PM
Urbanecm mentioned this in rECOM285a2f9101af: AbstractProvider: Normalize top level config correctly.
Maintenance_bot removed a project: Patch-For-Review.Tue, Nov 5, 9:30 PM
Stashbot added a comment.Tue, Nov 5, 9:34 PM

Mentioned in SAL (#wikimedia-operations) [2024-11-05T21:34:30Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1087560|AbstractProvider: Normalize top level config correctly (T379094)]], [[gerrit:1087561|AbstractProvider: Normalize top level config correctly (T379094)]]

Stashbot added a comment.Tue, Nov 5, 9:47 PM

Mentioned in SAL (#wikimedia-operations) [2024-11-05T21:47:10Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1087560|AbstractProvider: Normalize top level config correctly (T379094)]], [[gerrit:1087561|AbstractProvider: Normalize top level config correctly (T379094)]] (duration: 12m 39s)

Urbanecm_WMF added a comment.Tue, Nov 5, 9:48 PM

This should now be in production.

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.2; 2024-11-05); removed MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).Tue, Nov 5, 10:00 PM
Etonkovidova moved this task from QA to Test in Production on the Growth-Team (Current Sprint) board.Wed, Nov 6, 12:13 AM
Etonkovidova closed this task as Resolved.Thu, Nov 7, 9:11 PM
Etonkovidova subscribed.

Checked on wmf.2 - no error reports, see logstash link. The last timestamp is Nov 5, 2024 @ 21:03:34.732 (for wmf.1).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits