[go: up one dir, main page]

Move cryptography packages

Depends on

Follow-up issues:

MR purpose

How to review

Given the size of the cryptography team's codebase being transferred to the main repo, this is a very large MR. Reviewers should not review the code itself, but rather that its integration in the repo is correct. To this end, the main changes to be reviewed are those to manifest/main.ml, which defines the structure of these new libraries. The goal has been to keep as close as possible to the original build setup while also following Tezos conventions. The dune files that have been recreated this way are listed below. Reviewers should also check the changes to the protocol environment structs in src/lib_protocol_environment/structs/v8_plonk.ml and to the dummy zk rollup in src/proto_alpha/lib_protocol/test/helpers/dummy_zk_rollup.ml

Reviewers can diff the original source code and the one imported in tezos/tezos. The code is the same as on the main branch of these repos, with the only exceptions being:

  1. Complying with semgrep rules
  2. Renaming dependencies
  3. Differences in formatting (output of make fmt)
  4. Files hierarchy: nested directories and (copy_files foo) have been removed and source files have been moved at the root of the src directory.

Give opinions on:

  • library names

Reviewers should check:

  • CI time is not increasing (@bsall)
  • no changes have been introduced in other codebase than small changes in the protocol to match the new version of PlonK (@ZaynahDargaye)

It is expected to have a drop in the test coverage (@arvidnl).

Here is the list of the new dune files and their original locations:

  • src/lib_distributed_internal/src/dune <- original
  • src/lib_distributed_internal/lwt/dune <- original
  • src/lib_bls12_381_signature/dune <- original
  • src/lib_bls12_381_signature/test/dune <- original
  • src/src/lib_bls12_381_hash/dune <- original
  • src/lib_bls12_381_hash/test/dune <- original
  • src/lib_‎mec/‎du‎ne <- original
  • src/lib_‎mec/test/‎du‎ne <- consolidation of dune files in ocaml-ec/test
  • src/lib_poly‎nomial/du‎ne <- original
  • src/lib_poly‎nomial/test/‎du‎ne <- original
  • src/lib_srs_extraction/dune <- original
  • src/lib_srs_extraction/test/dune <- original
  • src/lib_plompiler/dune <- original
  • src/lib_plonk/dune <- original
  • src/lib_aplonk/plonk-aggregation/dune <- original
  • src/lib_aplonk/dune <- original
  • src/lib_distributed_plonk/plonk-distribution/dune <- original
  • src/lib_distributed_plonk/communication/dune <- original
  • src/lib_distributed_plonk/dune <- original
  • src/lib_plonk/test/dune <- original
  • src/lib_plonk/test_plompiler/dune <- original
  • src/lib_distributed_plonk/test/dune <- original
  • src/lib_aplonk/test/dune <- original
  • src/lib_epoxy_tx <- original
  • src/lib_epoxy_tx/test <- original
Edited by Raphaël Proust

Merge request reports

Loading