[go: up one dir, main page]

Proto/Michelson: no comparable type in sets and maps

Context

Here are a few commits I wrote some time ago when trying to merge ty and comparable_ty. I needed to break the dependency of sets/maps modules on comparable types.

The recent round-trip issue showed it is indeed a good idea to not have values containing types. It is here done for sets and maps. Doing it for big maps is left as an exercise for the first reviewer ;-)

  • I need to check whether cache sizes need to updated
    • I'd say there's nothing to do because I'm removing a value from Boxed_Set/Map and adding one to Boxed_Set/Map_OPS

Manually testing the MR

CI

Checklist

  • [ ] Document the interface of any function added or modified (see the coding guidelines)
  • [ ] Document any change to the user interface, including configuration parameters (see node configuration)
  • Provide automatic testing (see the testing guide).
  • [ ] For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, the Development Version section of CHANGES.md for everything else).
  • Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR
Edited by Mehdi Bouaziz

Merge request reports

Loading