CIAO: before_merging/scheduled, pt 4: test (2)

Stack

• !12377 (merged): Generation check
• !12378 (merged): before_merging/scheduled -- scaffolding
• !12382 (merged): before_merging/scheduled -- sanity, packaging
• !12397 (merged): before_merging/scheduled -- build
• !12490 (merged): before_merging/scheduled -- test (1)
• !12557 (merged): fix issue in !12490 (merged)
• !12556 (merged): before_merging/scheduled -- test (2) <- You are here

What

Part of the CIAO translation of the test stage for the before_merging/scheduled pipelines.

Why

How

No surprises here. Jobs are split per pipeline like in previous MRs. I prefix the branch with some refactoring commits. I change the arm64 unit job a bit to make it more coherent w.r.t. the other jobs.

Manually testing the MR

This MR is best reviewed commit-per-commit for the OCaml part. Commits should have a message explaining any non-obvious changes.

For the generated YML, do review the result of these commands (see previous MRs like !11501 (merged) for setup instructions for gci-tezos):

$ gci-tezos diff-full-config master . master_branch,test_release_tag,release_tag,non_release_tag,non_release_tag_test,beta_release_tag
$ gci-tezos diff-full-config master . schedule_extended_tests
$ gci-tezos diff-full-config master . before_merging

Note, depending on the state on local checkout, you might get results of the above commands by replacing master with git merge-base origin/master HEAD, where origin might change depending on the name of your tezos git remote. this also requires that you've run a fetch on origin such that it does not lag behind the branch in this MR.

The first command shows no diff, meaning that those environments are unaffected.

The second two commands will show a diff. There might be some changes that might not be obivuos -- it is perhaps easiest to review the diff commit per commit:

$ gci-tezos diff-full-config COMMIT^ COMMIT all-envs

and read the associated commit message to understand the diff. You can read the output in a pseudo-git log like format with the following script diff-log.sh:

#!/bin/sh

set -eu

range="$1"
shift

git log --format=%H "${range}" | while read -r commit; do
  git log --color=always -n1 "$commit"
  echo
  gci-tezos diff-full-config "${commit}^" "${commit}" "$@" || true
  echo
done | less -R --quit-if-one-screen

and now do ./diff-log.sh master..HEAD (assuming that is the range you want to review). It should allow you to read, commit-per-commit, the message of the commit and the fully merged diff per environment.

Checklist

• Document the interface of any function added or modified (see the coding guidelines)
• Document any change to the user interface, including configuration parameters (see node configuration)
• Provide automatic testing (see the testing guide).
• For new features and bug fixes, add an item in the appropriate changelog (docs/protocols/alpha.rst for the protocol and the environment, CHANGES.rst at the root of the repository for everything else).
• Select suitable reviewers using the Reviewers field below.
  • Select as Assignee the next person who should take action on that MR