[go: up one dir, main page]

feat(Alerts): Add visible border

What does this MR do?

  • Make border on alerts visible in both modes to ensure its visible bounds are detectable on different surfaces.
  • Make top gradient border visible in light mode to match current dark mode treatment.
  • Default border in both modes for visibility on neutral surfaces.

Screenshots or screen recordings

Surface Before After
Default CleanShot_2025-04-28_at_10.23.38_2x CleanShot_2025-05-13_at_11.54.26_2x
Subtle CleanShot_2025-04-28_at_10.27.13_2x CleanShot_2025-05-13_at_11.55.56_2x
Strong CleanShot_2025-04-28_at_10.27.51_2x CleanShot_2025-05-13_at_11.56.45_2x
Default CleanShot_2025-04-28_at_10.23.53_2x CleanShot_2025-05-13_at_11.57.03_2x
Subtle CleanShot_2025-04-28_at_10.29.35_2x CleanShot_2025-05-13_at_11.57.43_2x
Strong CleanShot_2025-04-28_at_10.30.06_2x CleanShot_2025-05-13_at_11.58.11_2x

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #3180 (moved)

Edited by Jeremy Elder

Merge request reports

Loading