[go: up one dir, main page]

fix(data import): use translated column names for validations as per user-set language by AarDG10 [frappe] PR#35046

From: https://github.com/frappe/frappe/pull/35046
Date: 2025-12-03 18:08:13+05:30

  • fix(data import): use translated column names for validations as per user-set language



Diagnostics

pre-commit failed for source commit: b3a89f8d3e9892b9673b5efb3f98a747e8f0b7ec
warning: The following rules have been removed and ignoring them has no effect:
    - UP038

RUF005 Consider `[row.row_number, *row.as_list()]` instead of concatenation
   --> frappe/core/doctype/data_import/importer.py:534:11
    |
532 |                 }
533 |
534 |         data = [[row.row_number] + row.as_list() for row in self.data]
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
535 |
536 |         warnings = self.get_warnings()
    |
help: Replace with `[row.row_number, *row.as_list()]`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).



Checkout instructions
# Checkout locally
git fetch upstream
git switch ft-pr-35046

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-35046

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports

Loading