[go: up one dir, main page]

fix(DX): log execution time in ms by sagarvora [frappe] PR#32278

Bot Dokosrequested to merge
ft-pr-32278 into develop

From: https://github.com/frappe/frappe/pull/32278
Date: 2025-04-23 22:40:23+05:30

  • fix(DX): log execution time in ms


Diagnostics

pre-commit failed for source commit: e6196672ca861a367836df3dbeffc7540950b101
[WARNING] top-level `default_stages` uses deprecated stage names (commit) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.

frappe/database/database.py:82:21: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
   |
80 |     MAX_COLUMN_LENGTH = 64
81 |
82 |     OPTIONAL_COLUMNS = ["_user_tags", "_comments", "_assign", "_liked_by"]
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RUF012
83 |     DEFAULT_SHORTCUTS = ["_Login", "__user", "_Full Name", "Today", "__today", "now", "Now"]
84 |     STANDARD_VARCHAR_COLUMNS = ("name", "owner", "modified_by")
   |

frappe/database/database.py:83:22: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
   |
82 |     OPTIONAL_COLUMNS = ["_user_tags", "_comments", "_assign", "_liked_by"]
83 |     DEFAULT_SHORTCUTS = ["_Login", "__user", "_Full Name", "Today", "__today", "now", "Now"]
   |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RUF012
84 |     STANDARD_VARCHAR_COLUMNS = ("name", "owner", "modified_by")
85 |     DEFAULT_COLUMNS = ["name", "creation", "modified", "modified_by", "owner", "docstatus", "idx"]
   |

frappe/database/database.py:85:20: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
   |
83 |     DEFAULT_SHORTCUTS = ["_Login", "__user", "_Full Name", "Today", "__today", "now", "Now"]
84 |     STANDARD_VARCHAR_COLUMNS = ("name", "owner", "modified_by")
85 |     DEFAULT_COLUMNS = ["name", "creation", "modified", "modified_by", "owner", "docstatus", "idx"]
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ RUF012
86 |     CHILD_TABLE_COLUMNS = ("parent", "parenttype", "parentfield")
87 |     MAX_WRITES_PER_TRANSACTION = 200_000
   |

Found 3 errors.


Checkout instructions 
# Checkout locally
git fetch upstream
git switch ft-pr-32278

# Alternatively, re-take the changes
git switch develop
ft take ft-pr-32278

# Make changes then rebase
git rebase -i develop

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease

Merge request reports