feat: Store printed PDF attachments on communication by ankush [frappe] PR#25439
From: https://github.com/frappe/frappe/pull/25439
Date: 2024-03-14 17:15:03+05:30
- feat: Store printed PDF attachments on communication (#25439)
Diagnostics
pre-commit failed for source commit: e76c29fcecdf3d67e1636538335d35afb8f98180
Run ruff linter and apply fixes..........................................Failed
- hook id: ruff
- exit code: 1
frappe/core/doctype/communication/email.py:278:30: RUF013 PEP 484 prohibits implicit `Optional`
frappe/email/doctype/email_queue/email_queue.py:756:26: RUF005 Consider `[r, *self.final_cc(), *self.bcc]` instead of concatenation
Found 2 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).
Checkout instructions
# Checkout locally
git fetch upstream
git switch ft-pr-25439
# Alternatively, re-take the changes
git switch develop
ft take ft-pr-25439
# Make changes then rebase
git rebase -i develop
# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue
# Force-push changes
git push --force-with-lease