feat: Letterhead Scripts & fix disappearing header in pdf by marination [frappe] PR#23907

From: https://github.com/frappe/frappe/pull/23907
Date: 2024-01-31 12:54:20+01:00

• fix: Check if header/footer html exists before trying to extract
• fix: Extract header/footer html into content to simplify things
• fix: Custom Script runs twice
• fix: Translate Letterhead information string
• feat: Letterhead scripts
• fix: Disappearing letterhead header in pdf

---

Diagnostics

pre-commit failed for source commit: 29e761671dc73edcc3b0a9745d825b8851a34e34
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

frappe/utils/pdf.py:108:10: F821 undefined name 'cover_pages'
frappe/utils/pdf.py:119:8: F821 undefined name 'cover_pages'
frappe/utils/pdf.py:124:7: F821 undefined name 'cover_pages'


pre-commit failed for source commit: f77b99396e03372c08e576952b92632b4ede6a5f
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

frappe/utils/pdf.py:107:10: F821 undefined name 'cover_pages'
frappe/utils/pdf.py:118:8: F821 undefined name 'cover_pages'
frappe/utils/pdf.py:123:7: F821 undefined name 'cover_pages'


pre-commit failed for source commit: bcca1da8d841e985cbe304cf9cbb99e73475bbe4
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

frappe/utils/pdf.py:107:10: F821 undefined name 'cover_pages'
frappe/utils/pdf.py:118:8: F821 undefined name 'cover_pages'
frappe/utils/pdf.py:123:7: F821 undefined name 'cover_pages'


pre-commit failed for source commit: 4d2c4f020bac93bdd648c4d3c1f514891c41d908
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

frappe/utils/pdf.py:107:10: F821 undefined name 'cover_pages'
frappe/utils/pdf.py:118:8: F821 undefined name 'cover_pages'
frappe/utils/pdf.py:123:7: F821 undefined name 'cover_pages'




Suspicious changes found (dokos|telemetry|shipping_rule|capture_doc):
  c475a8d54426b8d3b9131d373b5b6d5a28e82f72 feat: Letterhead scripts

---

Checkout instructions

# Checkout locally
git fetch upstream
git switch ft-pr-23907

# Make changes then rebase
git rebase -i upstream/develop --reapply-cherry-picks

# Fix or ignore conflicts
git checkout --theirs .
git rebase --continue

# Force-push changes
git push --force-with-lease