Repository navigation
Way to disable 'Warning: Limited encoding support'? #481
Description
This warning is now permanently shown when building without iconv. While understanding the drawbacks, I'd argue that there may be cases/platforms where building against iconv isn't practical or isn't necessary. E.g. on Windows, building iconv is a challenge and even when done, it's a large dependency that needs to be shipped around. In cases where minizip2 is used in a controlled environment with known, or pure-ASCII filenames, it can work well without codepage conversion.
It'd be nice to have a way to avoid this warning and silently fall back to the transparent strncpy() method.
Activity
nmoinvaz commentedon May 26, 2020
Do you have any suggestions? Maybe we should only mention this in CMake?
vszakats commentedon May 26, 2020
Moving that (a.) to CMake would be nice, or, (b.) implement a
#definespecifically to enable the non-iconv branch (e.g.MZ_ENCODING_TRANSPARENT), or (c.) aHAVE_NO_ICONV#definewhich would have the same effect as noHAVE_ICONV, but would suppress the warning.[ My preference is (a.), (c.), (b.) ]
nmoinvaz commentedon May 26, 2020
I think we should do CMake too. Do you want to do a PR?
vszakats commentedon May 26, 2020
I'm not a "CMake-person", so I'd trust yours much better for this solution.
Move warning about limited encoding support to cmake. #481
Move warning about limited encoding support to cmake. #481