Repository navigation
Make [mz_zip.c] more modular #478
Description
In mz_zip.c the library check for both, HAVE_ZLIB and HAVE_LIBCOMP flags and then uses the Zlib interface even though on Apple platforms it might use the Libcomp interface that is "Catfishing" Zlib.
Wouldn't something like be better?
#if defined(HAVE_ZLIB)
else if (zip->file_info.compression_method == MZ_COMPRESS_METHOD_DEFLATE)
mz_stream_zlib_create(&zip->compress_stream);
#endif
#if defined(HAVE_LIBCOMP)
else if (zip->file_info.compression_method == MZ_COMPRESS_METHOD_DEFLATE)
mz_stream_libcomp_create(&zip->compress_stream);
#endif
Activity
karimhm commentedon May 10, 2020
When trying to compile the library on Apple platform
mz_strm_zlib.[h/c]andmz_strm_libcomp.[h/c]cannot coexist due to duplicated symbols issue.nmoinvaz commentedon May 26, 2020
Are you using CMake to generate xcode project? It should prevent this type of scenario.
karimhm commentedon May 26, 2020
No I'm using Swift Package Manager. I manually copied source files.
SilenceWater commentedon Aug 16, 2020
Making the project private with CocoapoDS won't unzip
Use COMPRESSION_ZLIB when compiling against Apple's libCompression. #478