Repository navigation
Using mz_stream_open() on buffered stream causes infinite recursion #216
Description
Using mz_stream_open() on a buffered stream seems to cause minizip to get stuck in infinite recursion.
For example, if I run this sample program: https://gist.github.com/chenxiaolong/dbab3fbef51b9d0fa969e220dbb85967, it hangs indefinitely and the stack trace shows:
[build] pstack $(pidof a.out)
#0 mz_stream_open (stream=0x16f4290, path=0x7ffc1a039e70 "/tmp/foobar.zip", mode=1) at /stuff/Android/DualBootPatcher/minizip.cxl/src/mz_strm.c:26
#1 0x000000000040134f in main (argc=2, argv=0x7ffc1a0396d8) at test.c:66
I haven't looked too deeply into the code, but should these two functions be referring to the base stream instead of the buf stream?
Activity
Fixed bugs in buffered stream. #216
nmoinvaz commentedon Jan 2, 2018
Yes you are right it should have been referencing the base stream. I have made some changes and added buffering into the test app. Let me know if you have any more issues.
chenxiaolong commentedon Jan 2, 2018
Thank you! I'll give it a try after work today.
chenxiaolong commentedon Jan 3, 2018
This seems to be working fine now. Thanks for fixing it!