Repository navigation
Reloadable buffer pools - #6447
Merged
Merged
Conversation
jdegoes
reviewed
Mar 18, 2022
| _ <- threadsStartedTotal.launch(schedule.updateMetrics) | ||
| _ <- threadsDeadlocked.launch(schedule.updateMetrics) | ||
| _ <- threadsDeadlockedMonitor.launch(schedule.updateMetrics) | ||
| _ <- ZIO.acquireRelease(refreshThreadStateCounts(threadMXBean).repeat(schedule.updateMetrics).forkDaemon)( |
Member
There was a problem hiding this comment.
Should this be:
ZIO.acquireRelease(ZIO.interruptibly(refreshThreadStateCounts(threadMXBean).repeat(schedule.updateMetrics).)forkDaemon)(Otherwise it will hang shutdown because it can't be interrupted. Please make this change for all the other ZIO.acquireRelease ones.
Also, maybe we are missing something to accomplish this?
e.g. .scheduleBackground which could return ZIO[Scope, ...] and handle this messy part.
jdegoes
requested changes
Mar 18, 2022
Member
There was a problem hiding this comment.
Looks really good! I have have one comment on ZIO.acquireRelease hanging the finalizers because the acquire action is not interruptible.
jdegoes
reviewed
Mar 18, 2022
| * metrics | ||
| */ | ||
| final case class JvmMetricsSchedule( | ||
| updateMetrics: Schedule[Any, Any, Unit], |
Member
There was a problem hiding this comment.
Let's change the return type of these two schedules to Any, e.g.:
Suggested change
| updateMetrics: Schedule[Any, Any, Unit], | |
| updateMetrics: Schedule[Any, Any, Any], |
etc.
jdegoes
previously approved these changes
Mar 18, 2022
jdegoes
previously approved these changes
Mar 18, 2022
jdegoes
reviewed
Mar 18, 2022
| final def scheduleBackground[R1 <: R, B](schedule: => Schedule[R1, Any, B])(implicit | ||
| trace: ZTraceElement | ||
| ): ZIO[R1 with Clock with Scope, E, B] = | ||
| ): ZIO[R1 with Clock with Scope, E, Fiber[Any, B]] = |
Member
There was a problem hiding this comment.
You can delete the type parameter B and use Any for that slot in Schedule.
jdegoes
approved these changes
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.