8000 5743 `assertTrue` ignores the label, if assigned to AssertionResult by jupposessho · Pull Request #6275 · zio/zio · GitHub
[go: up one dir, main page]

Skip to content

5743 assertTrue ignores the label, if assigned to AssertionResult - #6275

Merged
adamgfraser merged 2 commits into
zio:series/2.xfrom
jupposessho:5743-asserttrue-ignores-the-label-if-ass
Jan 25, 2022
Merged

adamgfraser merged 2 commits into
zio:series/2.xfrom
jupposessho:5743-asserttrue-ignores-the-label-if-ass

Conversation

@jupposessho
Copy link
Copy Markdown
Contributor

No description provided.

@kitlangton
Copy link
Copy Markdown
Member

Oh! Nicely done 😄

@jupposessho
Copy link
Copy Markdown
Contributor Author

Oh! Nicely done 😄

I did my best :D

@kitlangton kitlangton left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to follow up, seeing if I can better unify the APIs. But this is a lovely start.

@jupposessho
Copy link
Copy Markdown
Contributor Author

I'm going to follow up, seeing if I can better unify the APIs. But this is a lovely start.

Let me know if I can help with the follow up.

@adamgfraser
adamgfraser merged commit 6639501 into zio:series/2.x Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0