New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure ZnDraw connection #230

Merged

PythonFZ merged 76 commits into main from 200-secure-connection

Oct 19, 2023

Member

PythonFZ commented

•

ZnDraw/zndraw/static/World/systems/select.js

Lines 308 to 316 in c970fda

    
           this.socket.emit("modifier:run", { 
        
             name: "zndraw.modify.Delete", 
        
             params: {}, 
        
             atoms: this.cache.get(this.world.getStep()), 
        
             selection: this.world.getSelection(), 
        
             step: this.world.getStep(), 
        
             points, 
        
             segments, 
        
             url: window.location.href,

Only submit:

name
params
step?

atoms, selection, segments, url can be retreived in other ways.

check that the scene loads succesfully
opening a window multiple times will duplicate the e.g. selection menu
local applications might not want to use a token, e.g. running it locally the uuid should maybe default to None / make CLI option.
selection / change frame could also be a message distributed to all other windows.


          introduce session key, move selection and line to zndraw.ZnDraw

9af978b

PythonFZ linked an issue

that may be closed by this pull request

Secure Connection #200

Closed

1 task

PythonFZ marked this pull request as draft

September 23, 2023 09:30


          [pre-commit.ci] auto fixes from pre-commit.com hooks

d13eb75

for more information, see https://pre-commit.ci

codecov-commenter commented

•

Codecov Report

Merging #230 (f5d5f46) into main (33d1316) will decrease coverage by 7.42%.
The diff coverage is 27.25%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   48.75%   41.34%   -7.42%     
==========================================
  Files           7       13       +6     
  Lines         281     1028     +747     
==========================================
+ Hits          137      425     +288     
- Misses        144      603     +459

Files	Coverage Δ
tests/conftest.py	`77.77% <80.00%> (-2.23%)`	⬇️
zndraw/modify/__init__.py	`43.44% <50.00%> (ø)`
zndraw/settings.py	`42.37% <50.00%> (ø)`
zndraw/utils.py	`31.25% <33.33%> (ø)`
zndraw/analyse/__init__.py	`26.66% <40.00%> (ø)`
tests/test_zndraw.py	`26.66% <26.66%> (ø)`
zndraw/zndraw.py	`28.37% <25.56%> (-2.45%)`	⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

PythonFZ and others added 25 commits

October 2, 2023 21:50


          Merge branch 'main' into 200-secure-connection

77b6614


          move to zndraw.ZnDraw in seperate process

0e799d4


          [pre-commit.ci] auto fixes from pre-commit.com hooks

bc9b297

for more information, see https://pre-commit.ci


          use zndraw.ZnDraw for everything except schemas

e5e6c6a


          [pre-commit.ci] auto fixes from pre-commit.com hooks

6967a39

for more information, see https://pre-commit.ci


          only send messages to the room based on the token

1116b0f


          [pre-commit.ci] auto fixes from pre-commit.com hooks

5edd8ba

for more information, see https://pre-commit.ci


          remove code duplicate

9b81bfb


          Merge branch '200-secure-connection' of https://github.com/zincware/z…

80fa0cc

…ndraw into 200-secure-connection


          make token available through CLI

b95df17


          load scene when both client and webpage are ready

0574d08


          add code modal

dd478d5


          [pre-commit.ci] auto fixes from pre-commit.com hooks

97d4814

for more information, see https://pre-commit.ci


          fix linting

f5ce52e


          [pre-commit.ci] auto fixes from pre-commit.com hooks

9f5f68b

for more information, see https://pre-commit.ci


          try to fix the modifier

21ba37f


          Merge branch '200-secure-connection' of https://github.com/zincware/z…

d23a055

…ndraw into 200-secure-connection


          [pre-commit.ci] auto fixes from pre-commit.com hooks

df6c8fa

for more information, see https://pre-commit.ci


          small updates

16a8bfe


          [pre-commit.ci] auto fixes from pre-commit.com hooks

a848a4c

for more information, see https://pre-commit.ci


          update communication

bf1612e


          clean up

943086b


          bugfix; renamed uuid to token

c3261d4


          Merge branch 'main' into 200-secure-connection

c3fb76f


          Merge branch 'main' into 200-secure-connection

c38513c

PythonFZ and others added 25 commits

October 19, 2023 08:57


          bugfix

383559b


          move sleep statement before yield

aab83de


          fix logging

66cffd8


          fix uploading

5a85b6e


          fix download btn

fc7275c


          [pre-commit.ci] auto fixes from pre-commit.com hooks

a718278

for more information, see https://pre-commit.ci


          update + use indent

28a3883


          Merge branch '200-secure-connection' of https://github.com/zincware/z…

6e59f5d

…ndraw into 200-secure-connection


          update test

79a22fd


          bump version

6d1c21e


          use emit instead of call for analysis

43c4665


          [pre-commit.ci] auto fixes from pre-commit.com hooks

f91b98d

for more information, see https://pre-commit.ci


          add + use play/pause

87f05ba


          [pre-commit.ci] auto fixes from pre-commit.com hooks

265e5ea

for more information, see https://pre-commit.ci


          add ChangeType back

3bd8141


          Merge branch '200-secure-connection' of https://github.com/zincware/z…

1f4fab1

…ndraw into 200-secure-connection


          bump version

e234f81


          fix use-token + rename template for syntax

76d5a66


          [pre-commit.ci] auto fixes from pre-commit.com hooks

60413e7

for more information, see https://pre-commit.ci


          use logging

20cf332


          Merge branch '200-secure-connection' of https://github.com/zincware/z…

cde72b2

…ndraw into 200-secure-connection


          [pre-commit.ci] auto fixes from pre-commit.com hooks

d0bcad4

for more information, see https://pre-commit.ci


          remove unused code

fb50d72


          Merge branch '200-secure-connection' of https://github.com/zincware/z…

7f4a1d4

…ndraw into 200-secure-connection


          fix failing linters + remove unused code

f5d5f46

PythonFZ marked this pull request as ready for review

October 19, 2023 12:03

PythonFZ requested a review from phohenberger

October 19, 2023 15:09

phohenberger approved these changes

View reviewed changes

PythonFZ merged commit 97384e2 into main

4 checks passed

PythonFZ deleted the 200-secure-connection branch

October 19, 2023 16:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet