Repository navigation
deploy: close the psql session ext-keys-check.sh opens - #50
Merged
Merged
Conversation
`fly postgres connect` runs the SQL it is given on stdin and then stays at the psql prompt, so the script never returned: on its first use (0.3.0, #46) the session to the hosted database stayed open until it was killed from outside, after the query had already printed `(0 rows)`. The script now sends `\q` after the file, so it exits with the query. Signed-off-by: Yutaka Nishimura <ytk.nishimura@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fly postgres connectruns the SQL from stdin and then stays at the psql prompt, sodeploy/fly/ext-keys-check.shnever returned on its first use (0.3.0, #46): the session to the hosted database stayed open until it was killed, after the query had already printed(0 rows).The script now sends
\qafter the file, so it exits with the query. Verified withbash -nonly; the next pre-deploy check is the first run against the hosted database.