Repository navigation
README: the UI ships in the binary, and /whoami returns no roles (0.1.3) - #23
Merged
Merged
Conversation
The Status section still said the web UI was being built. It is compiled into the binary and is what the hosted service serves; only a debug build without web-dist falls back to the placeholder page, which is what the Web UI section below already says. The Identity table said GET /whoami returns the token's organisation roles. It returns the user, the scope and the namespaces (api/meta.rs), and nothing else; the UI reads a caller's role from the roster instead. Ends the 0.1.3 release: the organisation screens (#17), the roster rule documented as the token rule (#20), and the organisation page's empty state and admin-only controls (#21). Verified: cargo fmt --check; cargo clippy --workspace --all-targets -D warnings; cargo test -p evalhub-schema / -core / -query; just package; just semver-check. Refs #22 Signed-off-by: Yutaka Nishimura <ytk.nishimura@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.1.3. What changed since 0.1.2:
Organisations in the web UI (#17)
Settings creates an organisation (the creator is its first
admin); the organisation's namespace page shows its roster and adds, updates and removes members. Browser tests drive the flow against the release binary.The roster rule, documented as the token rule it is (#20)
GET /orgs/{org}/membersasks that the presented token names the organisation, like every other read. The module doc, the handler,/openapi.jsonand the README said membership was enough; they now say what the code does.docs/hosting.mdgains a section on making an organisation in two steps: create it, then issue a token that names it.The organisation page after creating one (#21)
A signed-in token that does not name the organisation now gets a line saying why the roster is missing and a link to Settings with the token form filled in; Settings fills the same form right after creating an organisation. Member controls appear only for an
admintoken of anadminmember, which is what the hub accepts.This pull request
README.md: §Status no longer says the UI is being built, and the/whoamirow names the fields the response has (user, scope, namespaces — no organisation roles). Carries the version bump to 0.1.3.Verification
cargo fmt --check;cargo clippy --workspace --all-targets -- -D warnings;cargo test -p evalhub-schema,-core,-query;just package(all three crates at 0.1.3, gate ok);just semver-check: no semver update required for any of the three. No Rust source changed in this pull request;evalhub-store/evalhub-servertests were not run here.The UI changes of #21 were deployed to the hosted service from
mainbefore this release and passeddeploy/fly/smoke.sh.Refs #22