Repository navigation
test(rerank): classify the rows-to-facts client in the egress inventory - #2998
Closed
amartya1523 wants to merge 1 commit into
Closed
amartya1523 wants to merge 1 commit into
amartya1523 wants to merge 1 commit into
Conversation
xerj-org#2988 added FactsClient (xerj autoindex <path> --facts <ns>), which the egress inventory flags as a new outbound client and fails main's Build + Test. It is built with node_blocking_builder and talks only to the command's node URL (--url, else localhost:9200), like esclient.rs, so it is a `xerj autoindex` client and DATA_EGRESS, docs/RERANK.md and the air-gapped recipe do not change.
Contributor
Author
|
Closing as a duplicate: #2990 (49083e4) landed the same classification of One thing this run surfaced that the egress failure had been masking: with the inventory passing, Build + Test here fails on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-assisted change, run and reviewed by @amartya1523.
What this changes, and why
mainis red on Build + Test since #2988 (rows-to-facts).xerj-rerank's egress inventory found a new outbound client and failed, as it is meant to:Every PR branched from current
maininherits the failure (for example #2996 and #2997).Classification.
facts_rows.rsis the client behindxerj autoindex <path> --facts <ns>. ItsFactsClient:crate::esclient::node_blocking_builder, the same builder the existingxerj autoindexclient (esclient.rs) uses;--url, elsehttp://localhost:9200);GET /_facts,GET /_facts/{ns}andPOST /_facts/{ns}/_bulk.Row text goes to the operator's own node, the same peer
esclient.rsalready sends documents to. So this is a command-line client of an already-published command, not a new way data leaves a node.Change: one
KNOWNentry,("xerj-autoindex/src/facts_rows.rs", Role::Client("xerj autoindex")), with a comment in the style of the neighbouring entries (xc.rs,staleness.rs).docs/RERANK.mdalready listsxerj autoindexamong the command-line clients, sothe_published_list_names_every_pathholds without a doc change.DATA_EGRESSand the air-gapped recipe are unchanged.Evidence
Checks
cargo fmt -p xerj-rerank -- --checkcargo test --profile quick -p xerj-rerank --test egress_inventory: 4 passed, 0 failed (3 passed, 1 failed on main)xerj autoindexis already in "Every way data leaves a XERJ node".Provenance
FactsClientconstruction and URL default infacts_rows.rs, on macOS 26 (aarch64),quickprofile, based on mainc4a07d194.xerj autoindex. If feat(autoindex): rows to facts (xerj autoindex <path> --facts <namespace>) #2988's author intends--urlto point at a remote node as a supported deployment, it is still the operator's own node, so the classification holds.