8000 feat(autoindex): add Gemini and Antigravity skill roots (#2644) by napattan · Pull Request #2926 · xerj-org/xerj · GitHub
[go: up one dir, main page]

Skip to content
8000

feat(autoindex): add Gemini and Antigravity skill roots (#2644) - #2926

Open
napattan wants to merge 1 commit into
xerj-org:mainfrom
napattan:feat/autoindex-gemini-antigravity-skills
Open

napattan wants to merge 1 commit into
xerj-org:mainfrom
napattan:feat/autoindex-gemini-antigravity-skills

Conversation

@napattan
@napattan napattan commented Nov 4, 2026
Copy link
Copy Markdown
Contributor

Written by an AI coding agent (Google Antigravity), run by @napattan, who has reviewed this change.

What this changes, and why

xerj_autoindex::skills::candidates() in engine/crates/xerj-autoindex/src/skills.rs currently discovers SKILL.md directories only under ~/.claude/skills, ~/.codex/skills, ~/.agents/skills, and project-local .claude/skills. Users of Gemini CLI (~/.gemini/skills) and Google Antigravity IDE (~/.gemini/config/skills) store SKILL.md definitions in those two roots, so xerj autoindex --skills missed them unless paths were passed manually.

This PR adds ("gemini", ".gemini/skills") and ("antigravity", ".gemini/config/skills") to skills::candidates() and updates the_four_folders_the_issue_names_in_order in skills.rs to assert all 6 candidate entries (5 home roots + 1 project root) in stable order (Refs #2644).

Dependencies / Merge order: This branch is independent against main (and compiles/passes on Linux/macOS CI standalone), but compiling and running cargo test -p xerj-autoindex --lib natively on Windows (x86_64-pc-windows-msvc) requires the #[cfg(unix)] test-import guards in branch fix/autoindex-windows-unit-tests (recommended merge order: fix/autoindex-windows-unit-tests first).

Evidence

PS> cargo test -p xerj-autoindex --lib skills::tests::
running 9 tests
test skills::tests::a_file_where_the_folder_would_be_is_not_a_skill_folder ... ok
test skills::tests::a_folder_whose_watch_fails_is_reported_while_the_others_watch ... ok
test skills::tests::a_project_opened_at_home_is_indexed_once ... ok
test skills::tests::an_index_under_the_bare_stem_gets_a_duplicate_note ... ok
test skills::tests::each_folder_runs_under_its_own_prefix ... ok
test skills::tests::missing_folders_are_skipped ... ok
test skills::tests::the_duplicate_note_prints_a_plain_windows_path ... ok
test skills::tests::the_four_folders_the_issue_names_in_order ... ok
test skills::tests::the_worst_exit_code_wins ... ok

test result: ok. 9 passed; 0 failed; 0 ignored; 0 measured; 1945 filtered out; finished in 0.01s

PS> cargo fmt -p xerj-autoindex -- --check
(exit 0)

Checks

  • cargo fmt --all (ran cargo fmt -p xerj-autoindex -- --check; workspace-wide --all on Windows hits os error 206 command-line length limit)
  • Scoped release build of the crates touched: cargo build --release -j 32 -p <crate>
  • cargo test -p <crate> passes (cargo test -p xerj-autoindex --lib skills::tes 8000 ts:: — 9 passed, 0 failed)
  • ES-YAML conformance suite at 0 failed (cargo run --release -p es-yaml-runner -- --dir tests/es-compat-yaml/yaml), or: not applicable because this change is docs/landing-only
  • New ES-compatible behaviour has a matching YAML case under engine/tests/es-compat-yaml/yaml/
  • Docs updated if user-visible behaviour changed
  • For non-trivial changes: the applicable audit in docs/CONTRIBUTION_REVIEW.md
  • For non-trivial changes: operational audit (N/A — does not modify any operational document or runnable shell recipe).

Not run:

  • cargo build --release -j 32 -p xerj-autoindex: verified via debug/test build (cargo test -p xerj-autoindex --lib).
  • ES-YAML conformance suite: not run locally because this change only appends two host directory candidates to xerj-autoindex's local --skills path list and does not touch Elasticsearch wire/query semantics.
  • Docs / cli.rs help text: kept this diff scoped solely to skills.rs; happy to update cli.rs / docs/recipes/find-a-skill.md if desired.

Provenance

  • Written by: AI coding agent (Google Antigravity), run by @napattan who has reviewed it
  • Verified (commands run, output observed):
    • cargo test -p xerj-autoindex --lib skills::tests:: (with fix/autoindex-windows-unit-tests applied on Windows 11 x86_64-pc-windows-msvc) -> 9 passed; 0 failed (0.01s)
    • cargo fmt -p xerj-autoindex -- --check -> exit 0
  • Assumed (not tested, and what would falsify it):
    • Assumed ~/.gemini/skills and ~/.gemini/config/skills are the standard global skill locations across macOS/Linux/Windows for Gemini CLI and Google Antigravity IDE (falsified if a platform release relocates global skills outside ~/.gemini).

@cla-bot
cla-bot Bot commented Nov 4, 2026
Copy link
Copy Markdown

Thanks for this contribution — we'd like to merge it.

Before we can, we need a signed Contributor License Agreement from: @napattan

It is a one-time thing per contributor, not per pull request. Read CLA.md, then open a small pull request adding your GitHub username to .contributors — that pull request is your signature, since it is made from your own account.

Once it is merged, comment @cla-bot check here and this check will go green. If you believe you are already covered, comment @cla-bot check and it will re-verify.

@xerj-org
xerj-org commented Nov 5, 2026
Copy link
Copy Markdown
Owner

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label Nov 5, 2026
@cla-bot
cla-bot Bot commented Nov 5, 2026
Copy link
Copy Markdown

Re-checking the CLA status for every commit author on this pull request…

skills::candidates() in engine/crates/xerj-autoindex/src/skills.rs
only scanned ~/.claude/skills, ~/.codex/skills, ~/.agents/skills, and
project-local .claude/skills, missing SKILL.md definitions installed
under ~/.gemini/skills (Gemini CLI) and ~/.gemini/config/skills
(Google Antigravity IDE).

Add ('gemini', '.gemini/skills') and ('antigravity', '.gemini/config/skills')
to skills::candidates() and update the_four_folders_the_issue_names_in_order
to assert all 6 candidate folders (5 home roots + 1 project root) in
stable order (cargo test -p xerj-autoindex --lib skills::tests:: -> 9 passed).

Written by an AI coding agent (Google Antigravity), run and reviewed by @napattan.
@napattan
napattan force-pushed the feat/autoindex-gemini-antigravity-skills branch from bcabe55 to 36b76bf Compare November 5, 2026 04:05
@napattan
napattan commented Nov 5, 2026
Copy link
Copy Markdown
Contributor Author

Rebased onto latest main (3f6aefa) to re-trigger CI after the transient GitHub Actions Windows runner disk disconnect (os error 433: A device which does not exist was specified while compiling libzerocopy) in Autoindex FD smoke (windows-latest).

@cla-bot check

@cla-bot
cla-bot Bot commented Nov 5, 2026
Copy link
Copy Markdown

Re-checking the CLA status for every commit author on this pull request…

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0