Repository navigation
fix(corpus index): honour the feedback opt-out in the indexing footer (#1903) - #1907
Merged
Merged
Conversation
…J_DISABLE_FEEDBACK `xerj corpus index` prints the autoindex completion footer, which appended AUTO_SEND_LINE unconditionally. It now checks xerj_common::feedback::enabled() like every other surface. Fixes #1903
Owner
Author
|
Xerj Merger made the fix: |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1903.
Bug:
xerj corpus indexprinted the field-report footer even withXERJ_DISABLE_FEEDBACK=trueor--disable-feedback. Every other surface honours that opt-out. The footer comes fromxerj-autoindex'swith_field_report, which addedAUTO_SEND_LINEunconditionally.Fix:
with_field_reportnow goes throughwith_field_report_if(hint, xerj_common::feedback::enabled()). That is the same check--helpandxerj feedbackuse: the flag anywhere on the command line, or the env var.Tests
field_report_footer_honours_the_opt_out. Allxerj-autoindextests pass (lib 1496 plus the integration tests), and clippy-D warningsis clean.XERJ_DISABLE_FEEDBACK=true xerj corpus index 0whitedev--java-process-inspector: the output has 0 "field report" lines. Before the fix, it printed the footer.--is indexed as-but verified as--, so the build always fails with "0 records" #1889, which fix(corpus): keep a literal -- in the index prefix so owner--repo corpora verify (#1889) #1906 fixes separately.