8000 Return 'pro' always for GHES installations by swinton · Pull Request #189 · wip/app · GitHub
[go: up one dir, main page]

Skip to content

Return 'pro' always for GHES installations - #189

Merged
gr2m merged 2 commits into
wip:masterfrom
swinton:swinton-patch-1
May 8, 2019
Merged

gr2m merged 2 commits into
wip:masterfrom
swinton:swinton-patch-1

Conversation

@swinton
@swinton swinton commented May 7, 2019
Copy link
Copy Markdown

👋 I'm working on a GitHub Enterprise Server-compatible version of WIP, I noticed that the getPlan is failing for GHES since there is no concept of a Marketplace listing.

Here's a 🚧 PR to address that, it felt reasonable to default the plan to pro for this type of user.

@gr2m
gr2m commented May 7, 2019
Copy link
Copy Markdown
Collaborator
8000

The change looks good! Could you add a test to cover the added lines?

@swinton swinton changed the title 🚧 Return 'pro' always for GHES installations Return 'pro' always for GHES installations May 8, 2019
@swinton
swinton commented May 8, 2019
Copy link
Copy Markdown
Author

Could you add a test to cover the added lines?

Added! Was having a hard time getting the process.env.GHE_HOST value restored, ending up using beforeEach / afterEach callbacks, but that might be overkill. I haven't used tap before, got any better suggestions?

@gr2m
gr2m commented May 8, 2019
Copy link
Copy Markdown
Collaborator

🤷🏻‍♂️works for me

@gr2m
gr2m merged commit 8059b01 into wip:master May 8, 2019
@wipbot
wipbot commented May 8, 2019
Copy link
Copy Markdown

🎉 This PR is included in version 3.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@wipbot wipbot added the released label May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0