8000 Updated Node.js engine and npm to recent version by abhijeetps · Pull Request #61 · wip/app · GitHub
[go: up one dir, main page]
Skip to content

Updated Node.js engine and npm to recent version - #61

Merged
gr2m merged 3 commits into
wip:masterfrom
abhijeetps:patch-2
Apr 9, 2018
Merged

Updated Node.js engine and npm to recent version#61
gr2m merged 3 commits into
wip:masterfrom
abhijeetps:patch-2

Conversation

@abhijeetps
@abhijeetps abhijeetps commented Apr 8, 2018
Copy link
Copy Markdown

No description provided.

gr2m
gr2m reviewed Apr 8, 2018
View reviewed changes
@gr2m gr2m left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I can’t change it because we deploy to now and last time I checked now couldn’t handle setting the node engine using the ^. And npm 5 is required implicitly by requiring node 8

Abhijeet Singh added 2 commits April 9, 2018 06:18
Abhijeet Singh
Another update from changes suggested
30c9106 
Replaced ^ with >=. Also, I have tested it by deploying using same Node.js and npm versions on Glitch, works fine. 😄
Abhijeet Singh
Merge pull request #1 from aps120797/aps120797-patch-1
936f27e 
Another update from changes suggested
@abhijeetps
abhijeetps commented Apr 9, 2018
Copy link
Copy Markdown
Author

Updated. 😄
Tested by deploying on Glitch. Works fine there.

@gr2m
gr2m commented Apr 9, 2018
Copy link
Copy Markdown
Collaborator

Can you please try to deploy to now.sh?

@abhijeetps
abhijeetps commented Apr 9, 2018
Copy link
Copy Markdown
Author

@gr2m , I deployed it on now.sh using now-cli. And, it's deployment is working fine. [See screenshot]
Note that by updating package.json by using >=, with this, it's updating Node.js to version 9.10.1, (most recent stable version with latest features).

"engines": {
    "node": ">=8.3.0",
    "npm": ">=5.3.0"
  },

And by just using the old statement, it's updating it to Node.js version 8.11.1 (most recent version of Node.js version 8).

"engines": {
    "node": "8",
  },

capture

@abhijeetps abhijeetps mentioned this pull request Apr 9, 2018
Closed
gr2m
gr2m approved these changes Apr 9, 2018
View reviewed changes
@gr2m gr2m left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking 👍
@gr2m
gr2m merged commit 9cf2ec2 into wip:master Apr 9, 2018
@gr2m
gr2m commented Apr 9, 2018
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m gr2m approved these changes
+1 more reviewer
@Anubhav-Bhargava Anubhav-Bhargava Anubhav-Bhargava approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abhijeetps @gr2m @Anubhav-Bhargava
0