8000 Support WIP labels by davidcelis · Pull Request #46 · wip/app · GitHub
[go: up one dir, main page]

Skip to content

Support WIP labels - #46

Merged
gr2m merged 2 commits into
wip:masterfrom
davidcelis:wip-labels
Feb 26, 2018
Merged

gr2m merged 2 commits into
wip:masterfrom
davidcelis:wip-labels

Conversation

@davidcelis
Copy link
Copy Markdown
Contributor

I'm a fan of marking a pull request as a work in progress using a [WIP] label, so this pull request adds support for labels whose names contain "wip" or "do not merge" just like commit messages or PR titles.

@gr2m gr2m left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m very reluctant to add more features / more code but your PR is fabulous and I think totally worth the additional 5 LOC :) Thanks a lot David 💐

@gr2m
gr2m merged commit 77aacc8 into wip:master Feb 26, 2018
@davidcelis
davidcelis deleted the wip-labels branch February 26, 2018 22:08
@gr2m
gr2m commented Feb 26, 2018
Copy link
Copy Markdown
Collaborator

oh I missed something, we also have to add add pull_request .labeled and pull_request.unlabeled to the events we listen to. Could you send a follow up PR? See #48

@davidcelis
Copy link
Copy Markdown
Contributor Author

Oh, d'oh! I forgot those had their own events 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0