8000 fix: Properly resolve and retain defsym target symbols by lapla-cogito · Pull Request #1402 · wild-linker/wild · GitHub
[go: up one dir, main page]
Skip to content

fix: Properly resolve and retain defsym target symbols - #1402

Merged
lapla-cogito merged 3 commits into
wild-linker:mainfrom
lapla-cogito:defsym_followup
Dec 22, 2025
Merged

fix: Properly resolve and retain defsym target symbols#1402
lapla-cogito merged 3 commits into
wild-linker:mainfrom
lapla-cogito:defsym_followup

Conversation

@lapla-cogito
@lapla-cogito lapla-cogito commented Dec 22, 2025
Copy link
Copy Markdown
Member

The implementation of defsym had the following issues:

  • When retrieving a symbol ID, we did not use the canonical ID.
  • In the case of a defsym that references another symbol, the referenced symbol was not correctly marked as used. As a result, the referenced symbol could be GC'd, potentially leaving an invalid reference.

fix #1399

@lapla-cogito
lapla-cogito merged commit cbfbb1f into wild-linker:main Dec 22, 2025
20 checks passed
@lapla-cogito
lapla-cogito deleted the defsym_followup branch December 22, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidlattimore davidlattimore davidlattimore approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

References to symbol aliases created by --defsym don't work

2 participants

@lapla-cogito @davidlattimore
0