8000 Update ja.i18n.json by msaus · Pull Request #602 · wekan/wekan · GitHub
[go: up one dir, main page]

Skip to content

Update ja.i18n.json - #602

Closed
msaus wants to merge 1 commit into
wekan:mobile-uxfrom
msaus:patch-1
Closed

msaus wants to merge 1 commit into
wekan:mobile-uxfrom
msaus:patch-1

Conversation

@msaus
@msaus msaus commented May 18, 2016 •
Copy link
Copy Markdown

I translated some Japanese here.


This change is Reviewable

I translated some Japanese here.
@CLAassistant
CLAassistant commented May 18, 2016 •
Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@AlexanderS
Copy link
Copy Markdown
Contributor

The translations are managed in transifex: https://www.transifex.com/wekan/wekan/dashboard/
You should update the translations there.

@msaus
msaus commented May 18, 2016
Copy link
Copy Markdown
Author

Oh. thanks for that. but, it looks like everything is translated already in transfix.

@mquandalle
Copy link
Copy Markdown

Closing as we manage translations in Transifex. I released v0.11.0-rc11 which includes an up to date Japanese translation.

@mquandalle mquandalle closed this Jul 20, 2016
xet7 added a commit that referenced this pull request Nov 11, 2026
The fix for #601 passed the paths to `bash -c` as arguments ("$1",
"$2") instead of pasting them into the script. That is safe in itself,
but it still hands a temporary or checkout path to a shell, and CodeQL
flagged js/shell-command-injection-from-environment again on the two
umask tests in tests/releaseDownloads.test.cjs. Those tests no longer
use a shell: fetch.sh runs as bash's program with its arguments, the
umask is set on the test's own process around the call and put back,
and `chmod +x` is fs.chmodSync. tests/macosSandbox.test.cjs, fixed the
same way for #601, now runs ls and touch as programs of sandbox-exec,
each path an argument.

The guard (tests/testShellPathsFromEnv.test.cjs) now also refuses any
value given to a shell's -c script as an argument - spawned or as a
wrapper's program - and the one other test that did so,
tests/dbConformanceWiring.test.cjs, passes its value in the environment.
Run against the files as they were, it names all three; its pattern
takes a backslash only as an escape, so a long file cannot make it
backtrack.

The findings were in tests, not in WeKan, so there is no attempt to
show in Admin Panel -> Problems.

Thanks to GitHub CodeQL and xet7 !
xet7 added a commit that referenced this pull request Nov 11, 2026
…ser 5.12.0 for Dependabot alert #188.

Thanks to GitHub CodeQL, dependabot and xet7 !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0