[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webview2] Fix error handling in CreateWebResourceResponse #2496

Merged
merged 1 commit into from
Mar 16, 2023
Merged

[webview2] Fix error handling in CreateWebResourceResponse #2496

merged 1 commit into from
Mar 16, 2023

Conversation

stffabi
Copy link
Collaborator
@stffabi stffabi commented Mar 16, 2023

The old error handling fails on WebView2Runtimes > 110.0.1587.69 and will show a "connection refused" page and reloads after a short time. After the reload everything wroked as expected again.

@stffabi
[webview2] Fix error handling in CreateWebResourceResponse
ec1832b 
The old error handling fails on WebView2Runtimes > 110.0.1587.69 and
will show a "connection refused" page and reloads after a short time.
After the reload everything wroked as expected again.
@stffabi stffabi requested a review from leaanthony March 16, 2023 08:51
@vercel
Copy link
vercel bot commented Mar 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
wails-v3-docs ❌ Failed (Inspect) Mar 16, 2023 at 8:51AM (UTC)

@stffabi stffabi marked this pull request as ready for review March 16, 2023 08:51
@stffabi
Copy link
Collaborator Author
stffabi commented Mar 16, 2023

There are potentially also other locations that doing the wrong error handling and don't take into account the HRESULT of the native methods and only rely on the GetLastError.

leaanthony
leaanthony approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member
@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice sleuthing! 🔍 👍

@stffabi
Copy link
Collaborator Author
stffabi commented Mar 16, 2023

Thanks for approving.

@stffabi stffabi merged commit 6ed0eb2 into master Mar 16, 2023
@stffabi stffabi deleted the bugfix/webview2-response-error-handling branch March 16, 2023 09:50
This was referenced Mar 19, 2023
Closed
Closed
@marcus-crane marcus-crane mentioned this pull request May 28, 2023
Closed
@stffabi stffabi mentioned this pull request Nov 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaanthony leaanthony leaanthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stffabi @leaanthony